add downstream.yml #1555
add downstream.yml #1555
Conversation
|
This is cool, but having it in every PR is maybe too much? Can we trigger it only on request same as people in Base do with |
|
Yeah something like invoking via a GH comment, and we automatically do it for release branches? Like when we create a branch for a new breaking release, this should be a sanity check that runs on that branch. |
|
Has this functionality been rolled into the FluxBot/ModelZookeeper or is it still WIP? |
|
Add your friendly neighborhood scientists to the list? 😅 |
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
|
Is this good to go? What's the best/fastest way to test it? |
.github/workflows/Downstream.yml
Outdated
| julia-version: [1] | ||
| os: [ubuntu-latest] | ||
| package: | ||
| - {user: FluxML, repo: ObjectDetector.jl, group: All} |
There was a problem hiding this comment.
Just a question, what does group mean here?
There was a problem hiding this comment.
Which test group, https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/test/runtests.jl#L18 so you can run a subset of the tests.
There was a problem hiding this comment.
Sounds like a simplified version of https://github.com/JuliaTesting/ReTest.jl
I guess is to tag this PR with "run downstream test" and then push an empty commit. |
|
There is a problem with the name. Also, is it actually working? More than here, it is important to have downstream integration in Zygote, which is more fragile |
|
We need to label this PR as "run downstream test" which I can't seem to do on mobile. That will trigger the workflow. |
There was a problem hiding this comment.
It seems like this works for most of our downstream targets. I am not sure why Transformers or ObjectDetector throw those errors. I recommend we merge this PR and solve those issues, tweak the trigger, etc. in a different PR.
Having running tests is better than nothing.
Add some downstream tests