Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some downstream testing #1033

Merged
merged 2 commits into from
Oct 17, 2021
Merged

Add some downstream testing #1033

merged 2 commits into from
Oct 17, 2021

Conversation

ChrisRackauckas
Copy link
Member

Adds downstream testing to CI, with a few application packages that should flex the API a bit.

@ChrisRackauckas
Add some downstream testing
8ce8b32 
Adds downstream testing to CI, with a few application packages that should flex the API a bit.
@DhairyaLGandhi
Copy link
Member

Related FluxML/Flux.jl#1555

@CarloLucibello
Copy link
Member

Can this be linked to bors so that we run downstream tests only before merging a PR instead of on every commit?

darsnack
darsnack approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on Slack comments, let's merge this now. We can always tweak it if it runs too much or takes too long, etc.

@CarloLucibello
Copy link
Member

CarloLucibello commented Oct 17, 2021 •
edited
Loading

An @inferred is failing in NNlib, we get Any instead of Float16 for elu, slightly annoying but not too serious.

I would remove FastAI and GeometricFlux to save some CI, they don't do anything particularly fancy and most of their functionality relies on Flux and NNlib.

DiffEqFlux seems stuck

@CarloLucibello CarloLucibello merged commit c9f4d97 into master Oct 17, 2021
@CarloLucibello CarloLucibello deleted the downstream branch October 17, 2021 05:25
@mcabbott
Copy link
Member

An @inferred is failing in NNlib, we get Any instead of Float16 for elu

Re-running tests on FluxML/NNlib.jl#347 , to fix or skip there.

@mcabbott mcabbott mentioned this pull request Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarloLucibello CarloLucibello CarloLucibello left review comments

@darsnack darsnack darsnack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChrisRackauckas @DhairyaLGandhi @CarloLucibello @mcabbott @darsnack