-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove some warnings in the test outputs #2143
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2143 +/- ##
==========================================
- Coverage 86.81% 86.40% -0.41%
==========================================
Files 19 19
Lines 1471 1471
==========================================
- Hits 1277 1271 -6
- Misses 194 200 +6 ☔ View full report in Codecov by Sentry. |
Only warnings left are of the type ┌ Warning: Wrapping a custom walk function as an `AnonymousWalk`. Future versions will only support custom walks that explicitly subtyle `AbstractWalk`.
│ caller = fmap(f::Function, x::Chain{Tuple{Dense{typeof(identity), Matrix{Float32}, Bool}, Dense{typeof(identity), Matrix{Float32}, Bool}, Dense{typeof(identity), Matrix{Float32}, Bool}}}, ys::NamedTuple{(:layers,), Tuple{Tuple{NamedTuple{(:weight, :bias, :σ), Tuple{Int64, Tuple{}, Tuple{}}}, NamedTuple{(:weight, :bias, :σ), Tuple{Int64, Tuple{}, Tuple{}}}, NamedTuple{(:weight, :bias, :σ), Tuple{Int64, Tuple{}, Tuple{}}}}}}; exclude::Function, walk::Function, cache::IdDict{Any, Any}, prune::Functors.NoKeyword) at maps.jl:7 I still have to investigate where they come from |
merge? |
Either this or #2139 is going to be a fun rebase, sadly. Are there any other PRs similarly affected? That (and git blame) are the objections to fixing white-space extensively, without other reasons for change. |
The issue with blame can be fixed via specifying ignored revs. Metalhead already does this. It's also why it makes sense to batch formatting changes where possible and ensure future code remains formatted. |
closing as outdated |
and also some formatting changes