Refactor fit and update
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #161 +/- ##
==========================================
- Coverage 91.32% 88.94% -2.38%
==========================================
Files 6 8 +2
Lines 265 208 -57
==========================================
- Hits 242 185 -57
Misses 23 23
Continue to review full report at Codecov.
|
1 task
|
@ayush-1506 Any chance you could give this a once over? |
|
@ablaom Sure, will take a look at it later today. |
ayush-1506
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
@ablaom Looks good! I glanced over the code and couldn't find any issues. Would love to give this a try once this is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a lot of repeated code. Specifically, it abstracts out the model-specific parts of
fitandupdateso that we can have a singlefitandupdatemethod for MLJFlux models. Based on my recent work on this repo, this change will save time in maintenance and adding features, and prevent bugs.A new entry to the readme explains further:
Adding new models to MLJFlux (advanced)
This section is mainly for MLJFlux developers. It assumes familiarity
with the MLJ model
API
If one subtypes a new model type as either
MLJFlux.MLJFluxProbabilisticorMLJFlux.MLJFluxDeterministic, theninstead of defining new methods for
MLJModelInterface.fitandMLJModelInterface.updateone can make use of fallbacks byimplementing the lower level methods
shape,build, andfitresult. See the this source code for an example.One still needs to implement a new
predictmethod.