-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce interface point for RNGs #164
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #164 +/- ##
==========================================
- Coverage 91.32% 88.67% -2.65%
==========================================
Files 6 8 +2
Lines 265 212 -53
==========================================
- Hits 242 188 -54
- Misses 23 24 +1
Continue to review full report at Codecov.
|
Closing in favour of #166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #160 .
Should not be merged until:
fit
andupdate
#161 has been mergedon which this is based.
The new
build
signatures are changed frombuild(model, n_in, n_out)
/build(model, n_in, n_out, n_channels)
toThis is breaking. I had thought to keep backwards compatibility with a fallback
but this doesn't work unless all new
build
methods haverng
explicitly typed in the signature, which is annoying (otherwise there is method ambiguity).