Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface point for RNGs #166

Merged
merged 12 commits into from
Jun 23, 2021
Merged

Add interface point for RNGs #166

merged 12 commits into from
Jun 23, 2021

Conversation

ablaom
Copy link
Collaborator

@ablaom ablaom commented Jun 18, 2021

Replaces #164

@ablaom ablaom mentioned this pull request Jun 18, 2021
1 task
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2021

Codecov Report

Merging #166 (d2b51af) into dev (6c48032) will increase coverage by 1.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #166      +/-   ##
==========================================
+ Coverage   88.94%   90.56%   +1.62%     
==========================================
  Files           8        8              
  Lines         208      212       +4     
==========================================
+ Hits          185      192       +7     
+ Misses         23       20       -3     
Impacted Files Coverage Δ
src/types.jl 100.00% <ø> (ø)
src/builders.jl 100.00% <100.00%> (+37.50%) ⬆️
src/classifier.jl 100.00% <100.00%> (ø)
src/common.jl 96.55% <100.00%> (+0.18%) ⬆️
src/image.jl 100.00% <100.00%> (ø)
src/regressor.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c48032...d2b51af. Read the comment docs.

@ablaom ablaom requested a review from ayush-1506 June 21, 2021 03:41
@ablaom
Copy link
Collaborator Author

ablaom commented Jun 21, 2021

@ayush-1506 Could you please review?

@ayush-1506
Copy link
Member

Sure, will review this later today.

src/builders.jl Outdated Show resolved Hide resolved
@ablaom ablaom merged commit 4bcde16 into dev Jun 23, 2021
@ablaom ablaom deleted the rng-interface-point2 branch June 23, 2021 21:24
This was referenced Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants