restrict AdamW's fields to Float64 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcabbott
reviewed
Dec 12, 2024
src/rules.jl
Outdated
| epsilon::T3 | ||
| struct AdamW <: AbstractRule | ||
| eta::Float64 | ||
| beta::Float64 |
There was a problem hiding this comment.
This won't work, function AdamW(η, β = (0.9, 0.999), λ = 0.0...
Yes, someone complained that they had a use case for Descent with complex eta. Maybe discussed in the original PR. |
CarloLucibello
commented
Dec 12, 2024
mcabbott
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per comment #198 (comment),
since we do it for any other rule (explicitly or through
@def) except forDescent.Is there any reason why
Descentis left out @mcabbott ?