Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict AdamW's fields to Float64 #199

Merged
merged 2 commits into from
Dec 12, 2024
Merged

restrict AdamW's fields to Float64 #199

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d49bbf8
restrict to Float64 for AdamW
CarloLucibello Dec 12, 2024
a0353f5
Update src/rules.jl
CarloLucibello Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/rules.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,11 +528,11 @@ Implemented as an [`OptimiserChain`](@ref) of [`Adam`](@ref) and [`WeightDecay`]
The previous rule, which is closer to the original paper, can be obtained by setting `AdamW(..., couple=false)`.
See [this issue](https://github.com/FluxML/Flux.jl/issues/2433) for more details.
"""
struct AdamW{T1,T2,T3,T4} <: AbstractRule
eta::T1
beta::T2
lambda::T4
epsilon::T3
struct AdamW <: AbstractRule
eta::Float64
beta::Float64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work, function AdamW(η, β = (0.9, 0.999), λ = 0.0...

CarloLucibello marked this conversation as resolved.
Show resolved Hide resolved
lambda::Float64
epsilon::Float64
couple::Bool
end

Expand Down
Loading