feat(forest-cloud): introduce local development environment for cloud projects #1199

Thenkei · 2024-10-22T13:34:32Z

Definition of Done

General

Write an explicit title for the Pull Request, following Conventional Commits specification
Test manually the implemented changes
Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

Consider the security impact of the changes made

Thenkei · 2024-10-28T09:38:01Z

packages/forest-cloud/src/services/dist-path-manager.ts

@@ -14,4 +14,8 @@ export default class DistPathManager {
  get distCodeCustomizations(): string {
    return path.join(this.cloudCustomizerPath, 'dist', 'code-customizations');
  }
+
+  get localDatasources(): string {
+    return path.join(this.cloudCustomizerPath, 'datasources.json');


TODO: Change it to js

JS file should looks like.

/** * @return {Record<string, (import('@forestadmin/forest-cloud').MongoConnectionParams | import('@forestadmin/forest-cloud').SqlConnectionParams)>} */ export default () => ({ main: { uri: "postgres://forest:secret@localhost:5435/full-hosted" }, new: { uri: "postgres://forest:secret@localhost:5435/full-hosted" } });

packages/forest-cloud/src/services/starting-agent-locally.ts

Thenkei · 2024-10-31T16:02:55Z

packages/forest-cloud/src/services/http-server.ts

+          url: `${this.serverUrl}/api/full-hosted-agent/development-environment-for-user`,
+          method: 'POST',
+          headers: this.headers,
+          data: { endpoint: `http://localhost:${process.env.PORT ?? 3351}` },


packages/forest-cloud/src/commands/start.ts

packages/forest-cloud/src/services/http-server.ts

packages/forest-cloud/src/services/starting-agent-locally.ts

packages/forest-cloud/src/services/dist-path-manager.ts

packages/forest-cloud/src/commands/start.ts

packages/forest-cloud/src/services/starting-agent-locally.ts

packages/forest-cloud/src/services/generate-datasource-config-file.ts

packages/forest-cloud/src/commands/start.ts

realSpok · 2024-11-05T21:14:49Z

I seem to have a default log level of debug, which is very verbose:

packages/forest-cloud/src/commands/bootstrap.ts

packages/forest-cloud/src/services/http-server.ts

# @forestadmin/forest-cloud [1.12.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forest-cloud@1.11.30...@forestadmin/forest-cloud@1.12.0) (2024-11-06) ### Features * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

forest-bot · 2024-11-06T11:35:13Z

🎉 This PR is included in version 1.12.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.11.11](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.11.10...example@1.11.11) (2024-11-12) ### Bug Fixes * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

# [1.53.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.52.2...@forestadmin/agent@1.53.0) (2024-11-12) ### Bug Fixes * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

forest-bot · 2024-11-12T09:56:18Z

🎉 This PR is included in version 1.11.11 🎉

The release is available on example@1.11.11

Your semantic-release bot 📦🚀

forest-bot · 2024-11-12T09:56:35Z

🎉 This PR is included in version 1.53.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

# [1.35.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.34.2...@forestadmin/forestadmin-client@1.35.0) (2024-11-15) ### Bug Fixes * **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b)) * change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7)) * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

forest-bot · 2024-11-15T09:28:27Z

🎉 This PR is included in version 1.35.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.5.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-replica@1.5.2...@forestadmin/datasource-replica@1.5.3) (2024-11-20) ### Bug Fixes * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

# [1.15.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.14.31...@forestadmin/datasource-sql@1.15.0) (2024-11-20) ### Bug Fixes * **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b)) * change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7)) * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82)) * **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

forest-bot · 2024-11-20T08:36:54Z

🎉 This PR is included in version 1.5.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-11-20T08:37:35Z

🎉 This PR is included in version 1.15.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.55.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.55.4...@forestadmin/datasource-customizer@1.55.5) (2024-11-27) ### Bug Fixes * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f)) * **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35)) * **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399)) * **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

## [1.1.40](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.39...@forestadmin/datasource-dummy@1.1.40) (2024-11-27) ### Bug Fixes * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f)) * **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35)) * **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399)) * **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

## [1.4.8](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.4.7...@forestadmin/plugin-aws-s3@1.4.8) (2024-11-27) ### Bug Fixes * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f)) * **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35)) * **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399)) * **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

## [1.1.13](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-export-advanced@1.1.12...@forestadmin/plugin-export-advanced@1.1.13) (2024-11-27) ### Bug Fixes * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f)) * **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35)) * **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399)) * **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

## [1.3.8](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.3.7...@forestadmin/plugin-flattener@1.3.8) (2024-11-27) ### Bug Fixes * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f)) * **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35)) * **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399)) * **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

forest-bot · 2024-11-27T10:14:40Z

🎉 This PR is included in version 1.55.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-11-27T10:15:19Z

🎉 This PR is included in version 1.1.40 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-11-27T10:16:16Z

🎉 This PR is included in version 1.4.8 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-11-27T10:16:55Z

🎉 This PR is included in version 1.1.13 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-11-27T10:17:34Z

🎉 This PR is included in version 1.3.8 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.3.26](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongo@1.3.25...@forestadmin/datasource-mongo@1.3.26) (2024-11-27) ### Bug Fixes * **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b)) * change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7)) * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a)) * **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f)) * **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35)) * **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399)) * **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **capabilities:** define native query connection capabilities ([#1220](#1220)) ([bd0fc7c](bd0fc7c)) * **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82)) * **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42)) ### Reverts * "chore(capabilities): define native query connection capabilities ([#1219](#1219))" ([290cde3](290cde3))

## [1.8.6](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.8.5...@forestadmin/datasource-mongoose@1.8.6) (2024-11-27) ### Bug Fixes * **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b)) * change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7)) * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a)) * **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f)) * **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35)) * **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399)) * **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **capabilities:** define native query connection capabilities ([#1220](#1220)) ([bd0fc7c](bd0fc7c)) * **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82)) * **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42)) ### Reverts * "chore(capabilities): define native query connection capabilities ([#1219](#1219))" ([290cde3](290cde3))

# [1.11.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.10.5...@forestadmin/datasource-sequelize@1.11.0) (2024-11-27) ### Bug Fixes * **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b)) * change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7)) * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a)) * **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f)) * **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35)) * **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399)) * **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **capabilities:** define native query connection capabilities ([#1220](#1220)) ([bd0fc7c](bd0fc7c)) * **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82)) * **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42)) ### Reverts * "chore(capabilities): define native query connection capabilities ([#1219](#1219))" ([290cde3](290cde3))

# [1.44.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.43.0...@forestadmin/datasource-toolkit@1.44.0) (2024-11-27) ### Bug Fixes * **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b)) * change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7)) * **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2)) * ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a)) * **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f)) * **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35)) * **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399)) * **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438)) * **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b)) ### Features * add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58)) * better logs during timeout ([#1208](#1208)) ([e844184](e844184)) * **capabilities:** define native query connection capabilities ([#1220](#1220)) ([bd0fc7c](bd0fc7c)) * **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82)) * **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c)) * **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42)) ### Reverts * "chore(capabilities): define native query connection capabilities ([#1219](#1219))" ([290cde3](290cde3))

forest-bot · 2024-11-27T14:35:16Z

🎉 This PR is included in version 1.3.26 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Thenkei added 2 commits October 22, 2024 15:33

feat: poc ongoing

07d7cc2

fix(cli-cloud): no datasources found error

b394954

Thenkei commented Oct 28, 2024

View reviewed changes

realSpok reviewed Oct 28, 2024

View reviewed changes

packages/forest-cloud/src/services/starting-agent-locally.ts Show resolved Hide resolved

Thenkei added 4 commits October 28, 2024 17:35

feat(cloud): create environment on start local dev cloud agent

a940775

feat: add saving locally config

1c35391

chore: merge branch 'main' into feat/local-cloud-development

7a06a80

fix: get or create

8bb18d9

DayTF reviewed Oct 30, 2024

View reviewed changes

packages/forest-cloud/src/services/starting-agent-locally.ts Show resolved Hide resolved

feat: make it work and some tests

4560a7c

Thenkei commented Oct 31, 2024

View reviewed changes

Dogan AY added 3 commits October 31, 2024 17:28

fix: lint

15644c6

fix: test mockup

98f71f8

fix: test ci

ca23570

EnkiP reviewed Nov 5, 2024

View reviewed changes

packages/forest-cloud/src/commands/start.ts Show resolved Hide resolved

EnkiP reviewed Nov 5, 2024

View reviewed changes

packages/forest-cloud/src/services/http-server.ts Show resolved Hide resolved

EnkiP reviewed Nov 5, 2024

View reviewed changes

packages/forest-cloud/src/services/starting-agent-locally.ts Outdated Show resolved Hide resolved

refactor: remove old comment

a242a2e