Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource sql): add option to see paranoid #1210

Merged
merged 9 commits into from
Nov 20, 2024

Conversation

arnaud-moncel
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@arnaud-moncel arnaud-moncel marked this pull request as ready for review November 19, 2024 14:27
Copy link
Member

@SteveBunlon SteveBunlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • V1
    • Paranoïd
      • with hook to display deleted
        • on non deleted record:
          • field deleted_at is editable ✅ but does nothing
          • deleting a record removes the record from the table view ✅ but does not change the deleted at value, removal is performed front side only without impacting the data
        • on deleted record:
          • field deleted_at is editable ✅ but does nothing
          • deleting a record removes the record from the table view ✅ but does not change the deleted at value, removal is performed front side only without impacting the data
      • without hook to display deleted
        • on non deleted record:
          • field deleted_at is editable ✅ but does nothing
          • deleting a record removes the record from the table view ✅
  • V2
    • Paranoïd
      • with hook to display deleted
        • on non deleted records:
          • field deleted_at is editable 🔴 does something (not linked to this contrib, but still needs to be taken into account as users without delete permissions could delete by changing deleted at value)
          • deleting a record removes the record from the table view ✅ but does not change the deleted at value, removal is
            performed front side only without impacting the data
        • on deleted record:
          • field deleted_at is editable ✅ but does nothing
          • deleting a record removes the record from the table view ✅ but does not change the deleted at value, removal is performed front side only without impacting the data
      • without hook to display deleted
        • on non deleted record:
          • field deleted_at is editable 🔴 does something (not linked to this contrib, but still needs to be taken into account as users without delete permissions could delete by changing deleted at value )
          • deleting a record removes the record from the table view ✅

The red circles should not be taken into account here, your contribution did not add those inconsistency with V1, they were existing before. No reasons for not merging it IMO.

@SteveBunlon
Copy link
Member

Previous woodshop for v1 agents when customers wanted to achieve the same result

https://docs.forestadmin.com/woodshop/how-tos/view-soft-deleted-records

@@ -53,6 +61,12 @@ export default class ModelBuilder {
...this.getAutoTimestampFieldsOverride(table),
});

if (displaySoftDeleted) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminds me of this

Co-authored-by: SteveBunlon <SteveBunlon@users.noreply.github.com>
Copy link

codeclimate bot commented Nov 20, 2024

Code Climate has analyzed commit f986392 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.2% (0.0% change).

View more on Code Climate.

@arnaud-moncel arnaud-moncel merged commit 2d2639c into main Nov 20, 2024
22 checks passed
@arnaud-moncel arnaud-moncel deleted the feat/datasource-sql/allow-see-paranoid branch November 20, 2024 08:27
forest-bot added a commit that referenced this pull request Nov 20, 2024
## [1.11.13](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.11.12...example@1.11.13) (2024-11-20)

### Features

* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.12.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.11.13 🎉

The release is available on example@1.11.13

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Nov 20, 2024
## [1.5.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-replica@1.5.2...@forestadmin/datasource-replica@1.5.3) (2024-11-20)

### Bug Fixes

* **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2))
* **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b))

### Features

* add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58))
* better logs during timeout ([#1208](#1208)) ([e844184](e844184))
* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))
* **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))
forest-bot added a commit that referenced this pull request Nov 20, 2024
# [1.15.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.14.31...@forestadmin/datasource-sql@1.15.0) (2024-11-20)

### Bug Fixes

* **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b))
* change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7))
* **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2))
* ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a))
* **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b))

### Features

* add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58))
* better logs during timeout ([#1208](#1208)) ([e844184](e844184))
* **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82))
* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))
* **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.5.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.15.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Nov 27, 2024
## [1.53.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.53.1...@forestadmin/agent@1.53.2) (2024-11-27)

### Bug Fixes

* **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f))
* **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35))
* **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399))
* **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438))

### Features

* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))
forest-bot added a commit that referenced this pull request Nov 27, 2024
## [1.55.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.55.4...@forestadmin/datasource-customizer@1.55.5) (2024-11-27)

### Bug Fixes

* **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2))
* **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f))
* **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35))
* **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399))
* **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438))
* **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b))

### Features

* add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58))
* better logs during timeout ([#1208](#1208)) ([e844184](e844184))
* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))
* **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))
forest-bot added a commit that referenced this pull request Nov 27, 2024
## [1.1.40](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.39...@forestadmin/datasource-dummy@1.1.40) (2024-11-27)

### Bug Fixes

* **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2))
* **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f))
* **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35))
* **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399))
* **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438))
* **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b))

### Features

* add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58))
* better logs during timeout ([#1208](#1208)) ([e844184](e844184))
* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))
* **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))
forest-bot added a commit that referenced this pull request Nov 27, 2024
## [1.4.8](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.4.7...@forestadmin/plugin-aws-s3@1.4.8) (2024-11-27)

### Bug Fixes

* **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2))
* **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f))
* **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35))
* **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399))
* **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438))
* **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b))

### Features

* add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58))
* better logs during timeout ([#1208](#1208)) ([e844184](e844184))
* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))
* **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))
forest-bot added a commit that referenced this pull request Nov 27, 2024
## [1.1.13](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-export-advanced@1.1.12...@forestadmin/plugin-export-advanced@1.1.13) (2024-11-27)

### Bug Fixes

* **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2))
* **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f))
* **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35))
* **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399))
* **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438))
* **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b))

### Features

* add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58))
* better logs during timeout ([#1208](#1208)) ([e844184](e844184))
* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))
* **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))
forest-bot added a commit that referenced this pull request Nov 27, 2024
## [1.3.8](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.3.7...@forestadmin/plugin-flattener@1.3.8) (2024-11-27)

### Bug Fixes

* **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2))
* **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f))
* **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35))
* **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399))
* **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438))
* **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b))

### Features

* add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58))
* better logs during timeout ([#1208](#1208)) ([e844184](e844184))
* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))
* **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.53.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.55.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.1.40 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.4.8 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.1.13 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.8 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Nov 27, 2024
## [1.3.26](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongo@1.3.25...@forestadmin/datasource-mongo@1.3.26) (2024-11-27)

### Bug Fixes

* **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b))
* change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7))
* **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2))
* ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a))
* **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f))
* **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35))
* **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399))
* **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438))
* **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b))

### Features

* add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58))
* better logs during timeout ([#1208](#1208)) ([e844184](e844184))
* **capabilities:** define native query connection capabilities ([#1220](#1220)) ([bd0fc7c](bd0fc7c))
* **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82))
* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))
* **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

### Reverts

*  "chore(capabilities): define native query connection capabilities ([#1219](#1219))" ([290cde3](290cde3))
forest-bot added a commit that referenced this pull request Nov 27, 2024
## [1.8.6](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.8.5...@forestadmin/datasource-mongoose@1.8.6) (2024-11-27)

### Bug Fixes

* **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b))
* change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7))
* **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2))
* ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a))
* **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f))
* **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35))
* **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399))
* **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438))
* **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b))

### Features

* add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58))
* better logs during timeout ([#1208](#1208)) ([e844184](e844184))
* **capabilities:** define native query connection capabilities ([#1220](#1220)) ([bd0fc7c](bd0fc7c))
* **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82))
* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))
* **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

### Reverts

*  "chore(capabilities): define native query connection capabilities ([#1219](#1219))" ([290cde3](290cde3))
forest-bot added a commit that referenced this pull request Nov 27, 2024
# [1.11.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.10.5...@forestadmin/datasource-sequelize@1.11.0) (2024-11-27)

### Bug Fixes

* **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b))
* change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7))
* **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2))
* ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a))
* **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f))
* **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35))
* **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399))
* **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438))
* **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b))

### Features

* add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58))
* better logs during timeout ([#1208](#1208)) ([e844184](e844184))
* **capabilities:** define native query connection capabilities ([#1220](#1220)) ([bd0fc7c](bd0fc7c))
* **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82))
* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))
* **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

### Reverts

*  "chore(capabilities): define native query connection capabilities ([#1219](#1219))" ([290cde3](290cde3))
forest-bot added a commit that referenced this pull request Nov 27, 2024
# [1.44.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.43.0...@forestadmin/datasource-toolkit@1.44.0) (2024-11-27)

### Bug Fixes

* **advanced-export:** export now uses context.filter ([#1198](#1198)) ([68cef9b](68cef9b))
* change error message when mixing pages and other elements in an action form ([#1201](#1201)) ([c06e8f7](c06e8f7))
* **forest-cloud:** generate datasource file on bootstrap ([#1203](#1203)) ([3a365f2](3a365f2))
* ignore inconsistent foreign key types ([#1202](#1202)) ([b5e8c6a](b5e8c6a))
* **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f))
* **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35))
* **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399))
* **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438))
* **typo:** bootstrap command ([#1206](#1206)) ([d60337b](d60337b))

### Features

* add support of projection on get route ([#1205](#1205)) ([5df3c58](5df3c58))
* better logs during timeout ([#1208](#1208)) ([e844184](e844184))
* **capabilities:** define native query connection capabilities ([#1220](#1220)) ([bd0fc7c](bd0fc7c))
* **capabilities:** register capabilities route for field filter operators ([#1197](#1197)) ([31edc82](31edc82))
* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))
* **forest-cloud:** introduce local development environment for cloud projects ([#1199](#1199)) ([e1cfa42](e1cfa42))

### Reverts

*  "chore(capabilities): define native query connection capabilities ([#1219](#1219))" ([290cde3](290cde3))
forest-bot added a commit that referenced this pull request Nov 27, 2024
## [1.35.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.35.0...@forestadmin/forestadmin-client@1.35.1) (2024-11-27)

### Bug Fixes

* **rename decorator:** properly map relation when renaming pk field ([#1217](#1217)) ([2de746f](2de746f))
* **security:** patch cross-spawn dependency vulnerabilities ([#1212](#1212)) ([79c5d35](79c5d35))
* **security:** patch express dependency vulnerabilities ([#1213](#1213)) ([a2c9399](a2c9399))
* **security:** patch tar dependency vulnerabilities ([#1214](#1214)) ([175b438](175b438))

### Features

* **capabilities:** define native query connection capabilities ([#1220](#1220)) ([bd0fc7c](bd0fc7c))
* **datasource sql:** add option to see paranoid ([#1210](#1210)) ([2d2639c](2d2639c))

### Reverts

*  "chore(capabilities): define native query connection capabilities ([#1219](#1219))" ([290cde3](290cde3))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.26 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants