Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events-subscription): allow to instantly refresh permissions when they change #692

Merged
merged 7 commits into from
May 25, 2023
Merged

feat(events-subscription): allow to instantly refresh permissions when they change #692

merged 7 commits into from
May 25, 2023

Conversation

Thenkei
Copy link
Contributor

@Thenkei Thenkei commented May 10, 2023

…

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@Thenkei Thenkei force-pushed the feat/refresh-using-event-source branch 4 times, most recently from 748f6ad to 7449f16 Compare May 15, 2023 14:24
@Thenkei Thenkei force-pushed the feat/refresh-using-event-source branch from 7449f16 to e3414bf Compare May 15, 2023 14:27
@Thenkei Thenkei marked this pull request as ready for review May 16, 2023 09:46
@Thenkei Thenkei requested a review from EnkiP May 16, 2023 09:47
@Thenkei Thenkei assigned EnkiP and unassigned EnkiP May 16, 2023
@Thenkei Thenkei removed the request for review from EnkiP May 16, 2023 09:47
@Thenkei Thenkei force-pushed the feat/refresh-using-event-source branch from ae03c87 to e197439 Compare May 16, 2023 13:17
ghusse
ghusse reviewed May 17, 2023
View reviewed changes
packages/agent/src/types.ts Outdated Show resolved Hide resolved
ghusse
ghusse reviewed May 17, 2023
View reviewed changes
packages/forestadmin-client/src/events-subscription/index.ts

const source = new EventSource(url, eventSourceConfig);

source.addEventListener('error', this.onEventError.bind(this));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we close the eventSource here and try to start another one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already handled. The event source tries to reconnect every second. I can look for the exact option to make it clear.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. Is there a configuration option regarding the delay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never responded sorry the delay is 1000ms and not configurable without some magical access to the eventSource object.

ghusse
ghusse reviewed May 17, 2023
View reviewed changes
packages/forestadmin-client/src/events-subscription/native-refresh-events-handler-service.ts
this.renderingPermissionService.invalidateAllCache();

// Emit RefreshCustomizations event
this.emit('RefreshCustomizations');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be inside this PR, as this is not handled yet?

Copy link
Contributor Author

@Thenkei Thenkei May 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented everything and than remove some parts. Do you think it's an issue since no one is listening for RefreshCustomizations? (The basement is here, just the additional behavior has not been implemented in this PR since the code was on the alpha branch)

@codeclimate
Copy link

codeclimate bot commented May 17, 2023

Code Climate has analyzed commit 85fd78e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 99.1%.

View more on Code Climate.

ghusse
ghusse reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@ghusse ghusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ✅ Code review
    • ✅  Use pure functions when possible
    • ✅  Performance concerns
    • ✅  Security concerns
    • ✅  The PR tackle one subject only
  • ✅ Automatic tests
    • ✅  Unit tests
    • ✖️  Integration tests
  • ✅ Manual tests
  • ✅ PR title
  • ✅ Destination branch
  • ⚠️  PR linked to the clickup task

Please link the related clickup task.

@Thenkei Thenkei merged commit e108183 into main May 25, 2023
@Thenkei Thenkei deleted the feat/refresh-using-event-source branch May 25, 2023 07:46
forest-bot added a commit that referenced this pull request May 25, 2023
@forest-bot
chore(release): @forestadmin/forestadmin-client@1.2.0 [skip ci]
494a44c 
# @forestadmin/forestadmin-client [1.2.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.1.14...@forestadmin/forestadmin-client@1.2.0) (2023-05-25)

### Features

* **events-subscription:** allow to instantly refresh permissions when they change ([#692](#692)) ([e108183](e108183))
forest-bot added a commit that referenced this pull request May 25, 2023
@forest-bot
chore(release): example@1.3.8 [skip ci]
19f7bbd 
## [1.3.8](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.3.7...example@1.3.8) (2023-05-25)

### Features

* **events-subscription:** allow to instantly refresh permissions when they change ([#692](#692)) ([e108183](e108183))
forest-bot added a commit that referenced this pull request May 25, 2023
@forest-bot
chore(release): @forestadmin/agent@1.9.0 [skip ci]
26486ee 
# [1.9.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.8.14...@forestadmin/agent@1.9.0) (2023-05-25)

### Features

* **events-subscription:** allow to instantly refresh permissions when they change ([#692](#692)) ([e108183](e108183))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.2.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.8 🎉

The release is available on example@1.3.8

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.9.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.6.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.2.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Jun 7, 2023
@forest-bot
chore(release): @forestadmin/datasource-customizer@1.8.0-alpha-webhoo…
10826fd 
…k-custom-actions.2 [skip ci]

# [1.8.0-alpha-webhook-custom-actions.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.8.0-alpha-webhook-custom-actions.1...@forestadmin/datasource-customizer@1.8.0-alpha-webhook-custom-actions.2) (2023-06-07)

### Bug Fixes

* **agent:** make sure that triggered actions from the frontend execute the right code even after an addition or removal of custom actions ([#706](#706)) ([9581036](9581036))
* **datasource-sql:** do not crash at connection time when using proxy without providing port ([#705](#705)) ([c3d7d60](c3d7d60))
* **datasource-sql:** export missing type ([#691](#691)) ([885de9e](885de9e))
* **datasource-sql:** send proper server name indication on tls connections through socks proxy ([#708](#708)) ([b072cee](b072cee))
* **ds-sql:** close the proxy when sequelize instance closes ([#694](#694)) ([d31276c](d31276c))
* improve errors from webhook endpoints ([#713](#713)) ([7e4f11f](7e4f11f))
* **in-app-onboarding:** do not force skipLibCheck on customers TS configuration ([#680](#680)) ([c374117](c374117))
* **typings:** allow incomplete records to be passed to collection.create ([#700](#700)) ([95483e2](95483e2))
* **webhook-custom-actions:** improve error reporting when calling a webhook ([#687](#687)) ([c3f7f9a](c3f7f9a))
* **webhook-custom-actions:** register webhook actions configured from the frontend ([#686](#686)) ([fd9334a](fd9334a))

### Features

* **datasource-sql:** enable to proxify the tcp connection by a socks5 proxy ([#690](#690)) ([971a712](971a712))
* **events-subscription:** allow to instantly refresh customizations when they change ([#704](#704)) ([8f4704e](8f4704e))
* **events-subscription:** allow to instantly refresh permissions when they change ([#692](#692)) ([e108183](e108183))
* **plugin-aws-s3:** add S3Client endpoint option ([#718](#718)) ([f725bbe](f725bbe))
forest-bot added a commit that referenced this pull request Jun 7, 2023
@forest-bot
chore(release): @forestadmin/datasource-dummy@1.0.31-alpha-webhook-cu…
5cdd19f 
…stom-actions.1 [skip ci]

## [1.0.31-alpha-webhook-custom-actions.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.0.30...@forestadmin/datasource-dummy@1.0.31-alpha-webhook-custom-actions.1) (2023-06-07)

### Bug Fixes

* **agent:** make sure that triggered actions from the frontend execute the right code even after an addition or removal of custom actions ([#706](#706)) ([9581036](9581036))
* **datasource-sql:** do not crash at connection time when using proxy without providing port ([#705](#705)) ([c3d7d60](c3d7d60))
* **datasource-sql:** send proper server name indication on tls connections through socks proxy ([#708](#708)) ([b072cee](b072cee))
* improve errors from webhook endpoints ([#713](#713)) ([7e4f11f](7e4f11f))
* **webhook-custom-actions:** improve error reporting when calling a webhook ([#687](#687)) ([c3f7f9a](c3f7f9a))
* **webhook-custom-actions:** register webhook actions configured from the frontend ([#686](#686)) ([fd9334a](fd9334a))

### Features

* **events-subscription:** allow to instantly refresh customizations when they change ([#704](#704)) ([8f4704e](8f4704e))
* **events-subscription:** allow to instantly refresh permissions when they change ([#692](#692)) ([e108183](e108183))
* **plugin-aws-s3:** add S3Client endpoint option ([#718](#718)) ([f725bbe](f725bbe))
* **webhook-custom-actions:** use webhook nocode smart actions configured in the frontend ([#671](#671)) ([7629699](7629699))
forest-bot added a commit that referenced this pull request Jun 7, 2023
@forest-bot
chore(release): @forestadmin/plugin-export-advanced@1.0.8-alpha-webho…
751b6b5 
…ok-custom-actions.1 [skip ci]

## [1.0.8-alpha-webhook-custom-actions.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-export-advanced@1.0.7...@forestadmin/plugin-export-advanced@1.0.8-alpha-webhook-custom-actions.1) (2023-06-07)

### Bug Fixes

* **agent:** make sure that triggered actions from the frontend execute the right code even after an addition or removal of custom actions ([#706](#706)) ([9581036](9581036))
* **datasource-sql:** do not crash at connection time when using proxy without providing port ([#705](#705)) ([c3d7d60](c3d7d60))
* **datasource-sql:** send proper server name indication on tls connections through socks proxy ([#708](#708)) ([b072cee](b072cee))
* improve errors from webhook endpoints ([#713](#713)) ([7e4f11f](7e4f11f))
* **webhook-custom-actions:** improve error reporting when calling a webhook ([#687](#687)) ([c3f7f9a](c3f7f9a))
* **webhook-custom-actions:** register webhook actions configured from the frontend ([#686](#686)) ([fd9334a](fd9334a))

### Features

* **events-subscription:** allow to instantly refresh customizations when they change ([#704](#704)) ([8f4704e](8f4704e))
* **events-subscription:** allow to instantly refresh permissions when they change ([#692](#692)) ([e108183](e108183))
* **plugin-aws-s3:** add S3Client endpoint option ([#718](#718)) ([f725bbe](f725bbe))
* **webhook-custom-actions:** use webhook nocode smart actions configured in the frontend ([#671](#671)) ([7629699](7629699))
forest-bot added a commit that referenced this pull request Jun 7, 2023
@forest-bot
chore(release): @forestadmin/plugin-flattener@1.0.21-alpha-webhook-cu…
eaee919 
…stom-actions.1 [skip ci]

## [1.0.21-alpha-webhook-custom-actions.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.0.20...@forestadmin/plugin-flattener@1.0.21-alpha-webhook-custom-actions.1) (2023-06-07)

### Bug Fixes

* **agent:** make sure that triggered actions from the frontend execute the right code even after an addition or removal of custom actions ([#706](#706)) ([9581036](9581036))
* **datasource-sql:** do not crash at connection time when using proxy without providing port ([#705](#705)) ([c3d7d60](c3d7d60))
* **datasource-sql:** send proper server name indication on tls connections through socks proxy ([#708](#708)) ([b072cee](b072cee))
* improve errors from webhook endpoints ([#713](#713)) ([7e4f11f](7e4f11f))
* **webhook-custom-actions:** improve error reporting when calling a webhook ([#687](#687)) ([c3f7f9a](c3f7f9a))
* **webhook-custom-actions:** register webhook actions configured from the frontend ([#686](#686)) ([fd9334a](fd9334a))

### Features

* **events-subscription:** allow to instantly refresh customizations when they change ([#704](#704)) ([8f4704e](8f4704e))
* **events-subscription:** allow to instantly refresh permissions when they change ([#692](#692)) ([e108183](e108183))
* **plugin-aws-s3:** add S3Client endpoint option ([#718](#718)) ([f725bbe](f725bbe))
* **webhook-custom-actions:** use webhook nocode smart actions configured in the frontend ([#671](#671)) ([7629699](7629699))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.8.0-alpha-webhook-custom-actions.2 🎉

The release is available on npm package (@alpha-webhook-custom-actions dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.31-alpha-webhook-custom-actions.1 🎉

The release is available on npm package (@alpha-webhook-custom-actions dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.8-alpha-webhook-custom-actions.1 🎉

The release is available on npm package (@alpha-webhook-custom-actions dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.21-alpha-webhook-custom-actions.1 🎉

The release is available on npm package (@alpha-webhook-custom-actions dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Jun 8, 2023
@forest-bot
chore(release): @forestadmin/datasource-customizer@1.8.0 [skip ci]
21ce67a 
# [1.8.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.7.2...@forestadmin/datasource-customizer@1.8.0) (2023-06-08)

### Bug Fixes

* **agent:** make sure that triggered actions from the frontend execute the right code even after an addition or removal of custom actions ([#706](#706)) ([9581036](9581036))
* **datasource-sql:** do not crash at connection time when using proxy without providing port ([#705](#705)) ([c3d7d60](c3d7d60))
* **datasource-sql:** send proper server name indication on tls connections through socks proxy ([#708](#708)) ([b072cee](b072cee))
* improve errors from webhook endpoints ([#713](#713)) ([7e4f11f](7e4f11f))
* **webhook-custom-actions:** improve error reporting when calling a webhook ([#687](#687)) ([c3f7f9a](c3f7f9a))
* **webhook-custom-actions:** register webhook actions configured from the frontend ([#686](#686)) ([fd9334a](fd9334a))

### Features

* allow to create webhook actions from the frontend ([#712](#712)) ([750a218](750a218))
* **events-subscription:** allow to instantly refresh customizations when they change ([#704](#704)) ([8f4704e](8f4704e))
* **events-subscription:** allow to instantly refresh permissions when they change ([#692](#692)) ([e108183](e108183))
* **plugin-aws-s3:** add S3Client endpoint option ([#718](#718)) ([f725bbe](f725bbe))
* **webhook-custom-actions:** use webhook nocode smart actions configured in the frontend ([#671](#671)) ([7629699](7629699))
forest-bot added a commit that referenced this pull request Jun 8, 2023
@forest-bot
chore(release): @forestadmin/datasource-dummy@1.0.31 [skip ci]
2cb92c7 
## [1.0.31](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.0.30...@forestadmin/datasource-dummy@1.0.31) (2023-06-08)

### Bug Fixes

* **agent:** make sure that triggered actions from the frontend execute the right code even after an addition or removal of custom actions ([#706](#706)) ([9581036](9581036))
* **datasource-sql:** do not crash at connection time when using proxy without providing port ([#705](#705)) ([c3d7d60](c3d7d60))
* **datasource-sql:** send proper server name indication on tls connections through socks proxy ([#708](#708)) ([b072cee](b072cee))
* improve errors from webhook endpoints ([#713](#713)) ([7e4f11f](7e4f11f))
* **webhook-custom-actions:** improve error reporting when calling a webhook ([#687](#687)) ([c3f7f9a](c3f7f9a))
* **webhook-custom-actions:** register webhook actions configured from the frontend ([#686](#686)) ([fd9334a](fd9334a))

### Features

* allow to create webhook actions from the frontend ([#712](#712)) ([750a218](750a218))
* **events-subscription:** allow to instantly refresh customizations when they change ([#704](#704)) ([8f4704e](8f4704e))
* **events-subscription:** allow to instantly refresh permissions when they change ([#692](#692)) ([e108183](e108183))
* **plugin-aws-s3:** add S3Client endpoint option ([#718](#718)) ([f725bbe](f725bbe))
* **webhook-custom-actions:** use webhook nocode smart actions configured in the frontend ([#671](#671)) ([7629699](7629699))
forest-bot added a commit that referenced this pull request Jun 8, 2023
@forest-bot
chore(release): @forestadmin/plugin-flattener@1.0.21 [skip ci]
66a2a56 
## [1.0.21](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.0.20...@forestadmin/plugin-flattener@1.0.21) (2023-06-08)

### Bug Fixes

* **agent:** make sure that triggered actions from the frontend execute the right code even after an addition or removal of custom actions ([#706](#706)) ([9581036](9581036))
* **datasource-sql:** do not crash at connection time when using proxy without providing port ([#705](#705)) ([c3d7d60](c3d7d60))
* **datasource-sql:** send proper server name indication on tls connections through socks proxy ([#708](#708)) ([b072cee](b072cee))
* improve errors from webhook endpoints ([#713](#713)) ([7e4f11f](7e4f11f))
* **webhook-custom-actions:** improve error reporting when calling a webhook ([#687](#687)) ([c3f7f9a](c3f7f9a))
* **webhook-custom-actions:** register webhook actions configured from the frontend ([#686](#686)) ([fd9334a](fd9334a))

### Features

* allow to create webhook actions from the frontend ([#712](#712)) ([750a218](750a218))
* **events-subscription:** allow to instantly refresh customizations when they change ([#704](#704)) ([8f4704e](8f4704e))
* **events-subscription:** allow to instantly refresh permissions when they change ([#692](#692)) ([e108183](e108183))
* **plugin-aws-s3:** add S3Client endpoint option ([#718](#718)) ([f725bbe](f725bbe))
* **webhook-custom-actions:** use webhook nocode smart actions configured in the frontend ([#671](#671)) ([7629699](7629699))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.8 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.8.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.31 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.21 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Jun 29, 2023
@forest-bot
chore(release): @forestadmin/datasource-mongoose@1.4.1 [skip ci]
913c889 
## [1.4.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.4.0...@forestadmin/datasource-mongoose@1.4.1) (2023-06-29)

### Bug Fixes

* add a timeout on superagent call ([#741](#741)) ([3b85766](3b85766))
* **agent:** add request identifier to context.caller ([#753](#753)) ([19a8618](19a8618))
* **agent:** handle json field in csv export ([#746](#746)) ([8437f02](8437f02))
* **agent:** improve error message when validating projections ([#683](#683)) ([5e1baa9](5e1baa9))
* **agent:** make sure that triggered actions from the frontend execute the right code even after an addition or removal of custom actions ([#706](#706)) ([9581036](9581036))
* **customizer:** crash at startup when using collections with native actions ([#681](#681)) ([abe3edf](abe3edf))
* **customizer:** validate fields on user facing collection interface ([#731](#731)) ([56d4278](56d4278))
* **datasource-dummy:** correct relation definition ([#682](#682)) ([2ff0c9e](2ff0c9e))
* **datasource-sql:** add proxy configuration when computing ssl ([#740](#740)) ([3ca8a5d](3ca8a5d))
* **datasource-sql:** do not crash at connection time when using proxy without providing port ([#705](#705)) ([c3d7d60](c3d7d60))
* **datasource-sql:** export missing type ([#691](#691)) ([885de9e](885de9e))
* **datasource-sql:** export missing types ([#737](#737)) ([4fa72e3](4fa72e3))
* **datasource-sql:** fix worker crash on authentication testing ([#736](#736)) ([e81f101](e81f101))
* **datasource-sql:** improve management of literal values to avoid bugs when introspection is stringified ([#720](#720)) ([615dcda](615dcda))
* **datasource-sql:** improve the connect management errors ([#721](#721)) ([1128e49](1128e49))
* **datasource-sql:** repair sqlite support ([#733](#733)) ([a1e1a86](a1e1a86))
* **datasource-sql:** send proper server name indication on tls connections through socks proxy ([#708](#708)) ([b072cee](b072cee))
* **ds-sql:** close the proxy when sequelize instance closes ([#694](#694)) ([d31276c](d31276c))
* improve errors from webhook endpoints ([#713](#713)) ([7e4f11f](7e4f11f))
* **in-app-onboarding:** do not force skipLibCheck on customers TS configuration ([#680](#680)) ([c374117](c374117))
* **rename field decorator:** throw when put space inside fieldName ([#748](#748)) ([5793eff](5793eff))
* **security:** patch semver dependency vulnerabilities ([#749](#749)) ([b0617c1](b0617c1))
* **typings:** allow incomplete records to be passed to collection.create ([#700](#700)) ([95483e2](95483e2))
* **webhook-custom-actions:** improve error reporting when calling a webhook ([#687](#687)) ([c3f7f9a](c3f7f9a))
* **webhook-custom-actions:** register webhook actions configured from the frontend ([#686](#686)) ([fd9334a](fd9334a))

### Features

* **agent:** allow to create update record custom actions from the frontend ([#729](#729)) ([e06ac79](e06ac79))
* **agent:** no-code update record should handle errors correctly ([#747](#747)) ([6c5e344](6c5e344))
* allow to create webhook actions from the frontend ([#712](#712)) ([750a218](750a218))
* **datasource-sql:** create a ssh tunnel when a user provide ssh options ([#730](#730)) ([a188765](a188765))
* **datasource-sql:** enable to proxify the tcp connection by a socks5 proxy ([#690](#690)) ([971a712](971a712))
* **events-subscription:** allow to instantly refresh customizations when they change ([#704](#704)) ([8f4704e](8f4704e))
* **events-subscription:** allow to instantly refresh permissions when they change ([#692](#692)) ([e108183](e108183))
* handle field names containing underscores on update record actions ([#735](#735)) ([d5d7661](d5d7661))
* **plugin-aws-s3:** add S3Client endpoint option ([#718](#718)) ([f725bbe](f725bbe))
* **webhook-custom-actions:** use webhook nocode smart actions configured in the frontend ([#671](#671)) ([7629699](7629699))
forest-bot added a commit that referenced this pull request Jun 29, 2023
@forest-bot
chore(release): @forestadmin/datasource-sequelize@1.3.2 [skip ci]
6df2590 
## [1.3.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.3.1...@forestadmin/datasource-sequelize@1.3.2) (2023-06-29)

### Bug Fixes

* add a timeout on superagent call ([#741](#741)) ([3b85766](3b85766))
* **agent:** add request identifier to context.caller ([#753](#753)) ([19a8618](19a8618))
* **agent:** handle json field in csv export ([#746](#746)) ([8437f02](8437f02))
* **agent:** make sure that triggered actions from the frontend execute the right code even after an addition or removal of custom actions ([#706](#706)) ([9581036](9581036))
* **customizer:** validate fields on user facing collection interface ([#731](#731)) ([56d4278](56d4278))
* **datasource-sql:** add proxy configuration when computing ssl ([#740](#740)) ([3ca8a5d](3ca8a5d))
* **datasource-sql:** do not crash at connection time when using proxy without providing port ([#705](#705)) ([c3d7d60](c3d7d60))
* **datasource-sql:** export missing type ([#691](#691)) ([885de9e](885de9e))
* **datasource-sql:** export missing types ([#737](#737)) ([4fa72e3](4fa72e3))
* **datasource-sql:** fix worker crash on authentication testing ([#736](#736)) ([e81f101](e81f101))
* **datasource-sql:** improve management of literal values to avoid bugs when introspection is stringified ([#720](#720)) ([615dcda](615dcda))
* **datasource-sql:** improve the connect management errors ([#721](#721)) ([1128e49](1128e49))
* **datasource-sql:** repair sqlite support ([#733](#733)) ([a1e1a86](a1e1a86))
* **datasource-sql:** send proper server name indication on tls connections through socks proxy ([#708](#708)) ([b072cee](b072cee))
* **ds-sql:** close the proxy when sequelize instance closes ([#694](#694)) ([d31276c](d31276c))
* improve errors from webhook endpoints ([#713](#713)) ([7e4f11f](7e4f11f))
* **rename field decorator:** throw when put space inside fieldName ([#748](#748)) ([5793eff](5793eff))
* **security:** patch semver dependency vulnerabilities ([#749](#749)) ([b0617c1](b0617c1))
* **typings:** allow incomplete records to be passed to collection.create ([#700](#700)) ([95483e2](95483e2))
* **webhook-custom-actions:** improve error reporting when calling a webhook ([#687](#687)) ([c3f7f9a](c3f7f9a))
* **webhook-custom-actions:** register webhook actions configured from the frontend ([#686](#686)) ([fd9334a](fd9334a))

### Features

* **agent:** allow to create update record custom actions from the frontend ([#729](#729)) ([e06ac79](e06ac79))
* **agent:** no-code update record should handle errors correctly ([#747](#747)) ([6c5e344](6c5e344))
* allow to create webhook actions from the frontend ([#712](#712)) ([750a218](750a218))
* **datasource-sql:** create a ssh tunnel when a user provide ssh options ([#730](#730)) ([a188765](a188765))
* **datasource-sql:** enable to proxify the tcp connection by a socks5 proxy ([#690](#690)) ([971a712](971a712))
* **events-subscription:** allow to instantly refresh customizations when they change ([#704](#704)) ([8f4704e](8f4704e))
* **events-subscription:** allow to instantly refresh permissions when they change ([#692](#692)) ([e108183](e108183))
* handle field names containing underscores on update record actions ([#735](#735)) ([d5d7661](d5d7661))
* **plugin-aws-s3:** add S3Client endpoint option ([#718](#718)) ([f725bbe](f725bbe))
* **webhook-custom-actions:** use webhook nocode smart actions configured in the frontend ([#671](#671)) ([7629699](7629699))
forest-bot added a commit that referenced this pull request Jun 29, 2023
@forest-bot
chore(release): @forestadmin/datasource-toolkit@1.5.1 [skip ci]
e3df582 
## [1.5.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.5.0...@forestadmin/datasource-toolkit@1.5.1) (2023-06-29)

### Bug Fixes

* add a timeout on superagent call ([#741](#741)) ([3b85766](3b85766))
* **agent:** add request identifier to context.caller ([#753](#753)) ([19a8618](19a8618))
* **agent:** handle json field in csv export ([#746](#746)) ([8437f02](8437f02))
* **agent:** improve error message when validating projections ([#683](#683)) ([5e1baa9](5e1baa9))
* **agent:** make sure that triggered actions from the frontend execute the right code even after an addition or removal of custom actions ([#706](#706)) ([9581036](9581036))
* **customizer:** crash at startup when using collections with native actions ([#681](#681)) ([abe3edf](abe3edf))
* **customizer:** validate fields on user facing collection interface ([#731](#731)) ([56d4278](56d4278))
* **datasource-dummy:** correct relation definition ([#682](#682)) ([2ff0c9e](2ff0c9e))
* **datasource-sql:** add proxy configuration when computing ssl ([#740](#740)) ([3ca8a5d](3ca8a5d))
* **datasource-sql:** do not crash at connection time when using proxy without providing port ([#705](#705)) ([c3d7d60](c3d7d60))
* **datasource-sql:** export missing type ([#691](#691)) ([885de9e](885de9e))
* **datasource-sql:** export missing types ([#737](#737)) ([4fa72e3](4fa72e3))
* **datasource-sql:** fix worker crash on authentication testing ([#736](#736)) ([e81f101](e81f101))
* **datasource-sql:** improve management of literal values to avoid bugs when introspection is stringified ([#720](#720)) ([615dcda](615dcda))
* **datasource-sql:** improve the connect management errors ([#721](#721)) ([1128e49](1128e49))
* **datasource-sql:** repair sqlite support ([#733](#733)) ([a1e1a86](a1e1a86))
* **datasource-sql:** send proper server name indication on tls connections through socks proxy ([#708](#708)) ([b072cee](b072cee))
* **ds-sql:** close the proxy when sequelize instance closes ([#694](#694)) ([d31276c](d31276c))
* improve errors from webhook endpoints ([#713](#713)) ([7e4f11f](7e4f11f))
* **in-app-onboarding:** do not force skipLibCheck on customers TS configuration ([#680](#680)) ([c374117](c374117))
* **rename field decorator:** throw when put space inside fieldName ([#748](#748)) ([5793eff](5793eff))
* **security:** patch semver dependency vulnerabilities ([#749](#749)) ([b0617c1](b0617c1))
* **typings:** allow incomplete records to be passed to collection.create ([#700](#700)) ([95483e2](95483e2))
* **webhook-custom-actions:** improve error reporting when calling a webhook ([#687](#687)) ([c3f7f9a](c3f7f9a))
* **webhook-custom-actions:** register webhook actions configured from the frontend ([#686](#686)) ([fd9334a](fd9334a))

### Features

* **agent:** allow to create update record custom actions from the frontend ([#729](#729)) ([e06ac79](e06ac79))
* **agent:** no-code update record should handle errors correctly ([#747](#747)) ([6c5e344](6c5e344))
* allow to create webhook actions from the frontend ([#712](#712)) ([750a218](750a218))
* **datasource-sql:** create a ssh tunnel when a user provide ssh options ([#730](#730)) ([a188765](a188765))
* **datasource-sql:** enable to proxify the tcp connection by a socks5 proxy ([#690](#690)) ([971a712](971a712))
* **events-subscription:** allow to instantly refresh customizations when they change ([#704](#704)) ([8f4704e](8f4704e))
* **events-subscription:** allow to instantly refresh permissions when they change ([#692](#692)) ([e108183](e108183))
* handle field names containing underscores on update record actions ([#735](#735)) ([d5d7661](d5d7661))
* **plugin-aws-s3:** add S3Client endpoint option ([#718](#718)) ([f725bbe](f725bbe))
* **webhook-custom-actions:** use webhook nocode smart actions configured in the frontend ([#671](#671)) ([7629699](7629699))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realSpok realSpok realSpok left review comments

@ghusse ghusse ghusse approved these changes

Assignees
No one assigned
Labels
released on @alpha-webhook-custom-actions released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Thenkei @forest-bot @ghusse @realSpok @EnkiP