Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing package.json dep - react-fast-compare #1478

Merged
merged 1 commit into from
Jan 30, 2020
Merged

fix: Missing package.json dep - react-fast-compare #1478

merged 1 commit into from
Jan 30, 2020

Conversation

quinnturner
Copy link
Contributor

As per this case study, victory-brush-container is missing a reference to react-fast-compare

As per this [case study](yarnpkg/berry#843), victory-brush-container is missing a reference to `react-fast-compare`
@boygirl
Copy link
Contributor

boygirl commented Jan 30, 2020

@quinnturner oh, interesting! It should be a direct dependency. I think the package still works because react-fast-compare is a dependency of victory-core which victory-brush-container depends on.

@boygirl boygirl merged commit a0eada6 into FormidableLabs:master Jan 30, 2020
@quinnturner quinnturner deleted the patch-3 branch January 30, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants