Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies in victory-histogram #1573

Merged
merged 1 commit into from
May 14, 2020

Conversation

Mike-Dax
Copy link
Contributor

@Mike-Dax Mike-Dax commented May 14, 2020

https://github.com/FormidableLabs/victory/blob/master/packages/victory-histogram/src/helper-methods.js

Requires both d3-scale and react-fast-compare without including them in the package.json.

This works by coincidence in some codebases but will fail in any using Yarn v2.

This has happened a couple of times before:

#1478
#1496
#1570

I would recommend adding a test to your CI that installs and runs some tests of the package using Yarn v2 to catch these errors before release, given these patch / minor changes break downstream dependencies.

@boygirl
Copy link
Contributor

boygirl commented May 14, 2020

@Mike-Dax Thanks for this PR! react-fast-compare and d3-scale are both dependencies of victory-core, which victory-histogram depends on, making it particularly unlikely for us to catch this issue. I'll update our CI setup as you recommend.

@boygirl boygirl merged commit bff62ea into FormidableLabs:master May 14, 2020
@boygirl
Copy link
Contributor

boygirl commented May 14, 2020

published in victory@34.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants