Add missing dependencies in victory-histogram #1573
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/FormidableLabs/victory/blob/master/packages/victory-histogram/src/helper-methods.js
Requires both
d3-scale
andreact-fast-compare
without including them in the package.json.This works by coincidence in some codebases but will fail in any using Yarn v2.
This has happened a couple of times before:
#1478
#1496
#1570
I would recommend adding a test to your CI that installs and runs some tests of the package using Yarn v2 to catch these errors before release, given these patch / minor changes break downstream dependencies.