Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS migrate: victory-axis #2379

Merged
merged 5 commits into from
Jul 25, 2022
Merged

TS migrate: victory-axis #2379

merged 5 commits into from
Jul 25, 2022

Conversation

ramenhog
Copy link
Contributor

@ramenhog ramenhog commented Jul 22, 2022

Description

This PR migrates victory-axis over to TypeScript 🙌

@ryan-roemer
Copy link
Member

Looks like CI failed on prettier formatting. You should be able to auto-fix with:

$ pnpm run format:fix

HTH!

@ramenhog ramenhog force-pushed the ts-migrate/victory-axis branch from 051d359 to 3845506 Compare July 22, 2022 23:28
@scottrippey
Copy link
Member

FYI I'm going to push up a fix for the CI problem, but my git creds need fixing, so just a min!

@ramenhog ramenhog marked this pull request as ready for review July 25, 2022 20:00
@ramenhog ramenhog requested a review from gksander July 25, 2022 20:00
Copy link
Contributor

@sblinde sblinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newer to TypeScript here but this looks good to me!

@ramenhog ramenhog merged commit a311c29 into main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants