Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infra/Bug: Fix format tasks #2380

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Infra/Bug: Fix format tasks #2380

merged 2 commits into from
Jul 22, 2022

Conversation

ryan-roemer
Copy link
Member

This is the cause of the CI failures in #2379

  • Pkg format incorrectly checked if lint succeeded first.
  • Root pkg fix needed conditional check.

@ryan-roemer ryan-roemer marked this pull request as ready for review July 22, 2022 23:04
scottrippey
scottrippey approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@scottrippey scottrippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramenhog ramenhog merged commit 55a893f into main Jul 22, 2022
@ryan-roemer ryan-roemer deleted the infra/fix-format-task branch July 23, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramenhog ramenhog ramenhog approved these changes

@scottrippey scottrippey scottrippey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryan-roemer @scottrippey @ramenhog