Merge pull request #78 from MichaelMcDonnell/fix-scroll-perf

Fix scroll down performance
FossifyOrg · Dec 29, 2024 · f29d203 · f29d203
2 parents 3385c28 + 76a2509
commit f29d203
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/app/src/main/kotlin/org/fossify/home/fragments/AllAppsFragment.kt b/app/src/main/kotlin/org/fossify/home/fragments/AllAppsFragment.kt
@@ -113,7 +113,10 @@ class AllAppsFragment(
                     shouldIntercept =
                         distance > 0 && binding.allAppsGrid.computeVerticalScrollOffset() == 0
                     if (shouldIntercept) {
-                        activity?.hideKeyboard()
+                        // Hiding is expensive, only do it if focused
+                        if (binding.searchBar.hasFocus()) {
+                            activity?.hideKeyboard()
+                        }
                         activity?.startHandlingTouches(touchDownY)
                         touchDownY = -1
                     }
@@ -221,7 +224,8 @@ class AllAppsFragment(
         binding.allAppsFastscroller.setPadding(leftListPadding, 0, rightListPadding, 0)
         binding.allAppsGrid.addOnScrollListener(object : OnScrollListener() {
             override fun onScrolled(recyclerView: RecyclerView, dx: Int, dy: Int) {
-                if (dy > 0 && binding.allAppsGrid.computeVerticalScrollOffset() > 0) {
+                // Hiding is expensive, only do it if focused
+                if (binding.searchBar.hasFocus() && dy > 0 && binding.allAppsGrid.computeVerticalScrollOffset() > 0) {
                     activity?.hideKeyboard()
                 }
             }