Fix scroll down performance #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrolling down was slow (see issue FossifyOrg#65) because the keyboard was being hidden every time there was a scroll down event. Hiding the keyboard is an expensive operation (found through profiling). They keyboard only needs to be hidden if the search bar is being used (in focus).
7 tasks
Same, live and learn I guess. I was gonna use the scroll state to determine when to hide the keyboard but this is nicer, thanks! |
|
Yeah, I tried a couple of different solutions until I landed on this one which was the simplest thing I could think of. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Scrolling down was slow (see issue #65) because the keyboard was being hidden every time there was a scroll down event. Hiding the keyboard is an expensive operation (found through profiling). They keyboard only needs to be hidden if the search bar is being used (in focus).
Before/After Screenshots/Screen Record
The before and after was captured with HWUI turned on and scrolling up and down. Notice that the bars look the same in the after and are a lot shorter.
Fixes the following issue(s)
Acknowledgement