Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::string for printable strings only #39

Closed
apkar opened this issue Jan 9, 2019 · 0 comments · Fixed by #194
Closed

Use std::string for printable strings only #39

apkar opened this issue Jan 9, 2019 · 0 comments · Fixed by #194
Labels
cleanup Code or design cleanup

Comments

@apkar
Copy link
Contributor

apkar commented Jan 9, 2019

In quite a few places we use std::string to store byte buffers that are not printable strings. We should use Standalone<StringRef> instead. And use std::string only for printable strings.
@apkar apkar added the cleanup Code or design cleanup label Jan 9, 2019
@apkar apkar changed the title Use std::string for printable strings only Use std::string for printable strings only Jan 9, 2019
@apkar apkar changed the title Use std::string for printable strings only Use std::string for printable strings only Jan 9, 2019
@apkar apkar mentioned this issue Feb 13, 2019
Merged
@apkar apkar mentioned this issue May 27, 2019
Merged
dongxinEric added a commit that referenced this issue May 30, 2019
@dongxinEric
Merge pull request #194 from apkar/string-to-stringref
3ba6ff4 
Resolves #39: Replacing usage of `std::string` with `StringRef` for `Datakey` and `DataValue`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Code or design cleanup
Projects
None yet
Milestone
No milestone
1 participant
@apkar