Resolves #39: Replacing usage of std::string with StringRef for Datakey and DataValue
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This should reduce number of memory copies a lot * Also it has better semantics `std::string` for human readable and `StringRef` binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the following reasons its bad to use
std::stringfor bytesstd::stringfor bytes is confusingstd::stringtoStringRefis dangerous, especially ifstd::stringis r-valuestd::stringtoStandalone<StringRef>is unnecessary extra copy. This is happening a lot.std::stringis passed back toFDB::Transaction::get()orFDB::Transaction::set(), which convert it toStringRefanyway. Semantics are very confusing.Resolves #39, even though we still have some bad usages of
std::string, the majority are changed.