-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spotify stops polling and then does not restart anymore automatically and without notification. #65
Comments
There is! You are looking for
A health check endpoint is a great idea. I don't have time to implement this right now but if you like to give it a go a submit a PR i'd be happy to merge it. |
Hello, I see you closed this, but it is not entirely clear to me how to fix this now. But thanks for letting me know it is possible to configure it via json configuration files! If you do not have a lot of time for a health check, I think a get request to a custom URL on a poll stopping or error coming up would already be enough for a lot of things |
I've recently rewritten the documentation and it now includes a schema explorer for each config file and the general To increase the polling attempts you could have a {
"sourceDefaults": {
"maxRequestRestries": 3,
"maxPollRetries": 12,
"retryMultiplier": 10
}
} Which will make MS:
No it is not. The ENV based config is for supporting the bare minimum setup for MS. On the code side I already have to structure all this user data into something equivalent to json (nested objects) so it's much easier to use config files for that input since I can easily validate and parse that complex/nested data. MS already has ~20 ENV variables I have to support alongside the regular config files and I don't plan on adding more if possible. EDIT: For your specific scenario you must have already setup a config directory since the spotify source has to store its credentials in a file anyway. It should be trivial to create a json file in the same directory. |
Hello FoxxMD, Thank you! I was just finished with my process of converting all the environment variables to jsons when you posted this. The documentation is showing nicely how to format the json files. It worked on first try. Thank you for showing me some values that I will use. |
Addresses #5 and #65 -- in default config use-cases where: * request/polling retry attempts are low * source was initially OK (auth OK, initial communication OK) * and there is a non-auth related *upstream* communication issue there is no fallback path for restarting source polling after upstream has normalized. This feat implements a scheduled heartbeat task that attempts to restart polling every 20 minutes if this scenario is valid so that a good source config will recover without user intervention.
I was checking my scrobbles and suddenly noticed that many scrobbles of the last days are missing. So I manually checked the logs of the multiscrobber and noticed that it stopped scrobbling tracks from spotify since half a month already. The tracks I played there are therefore lost now.
I think it would be best, if there was a container internal mechanism implemented that tries polling again after a defined time, because there is no way someone wants to constantly check if the scrobbling is still working.
Secondly, it would be great to have an additional email or other notification that can be configured to inform the user that there is an issue regarding something in multi-scrobbler.
Options to inform user about an issue with multi-scrobbler:
Logs are here:
The text was updated successfully, but these errors were encountered: