-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Implement endpoint or push notifications for source health checks #66
Comments
The webhook would probably also support REST notification services like gotify or notify.sh, correct? If so, that would be awesome, looking forward to that feature! |
* Implemented notifications for Gotify and Ntfy * Notifications pushed on: polling started, polling retry, polling stopped on error, scrobble client scrobble failure
* HTTP Status as primary indicator with messages in json response * No parameters in request aggregates all client/source statuses. Otherwise can use 'type' or 'name' parameters to restrict client/sources to aggregate
I've implemented webhooks for Gotify/Ntfy as well as a health check endpoint. Preview in Webhooks can be added to {
"sources": [...],
"clients": [...],
"webhooks": [
{
"type": "gotify",
"url": "..."
}
],
} For now, webhooks notifications only push for:
Health endpoint can be accessed at
|
This is one of the best things! Thanks for this. Now it can be monitored both using uptime-kuma /uptimerobot via /health endpoint and also via gotify. Awesome! I already tested it and it works flawlessly for me. I only suggest adding something to send a testmessage to test if the message is coming correctly, either by pressing "Ping gotify/ntfy" in webui, via accessing a URL (/notifytest or else) or via terminal command from within the docker container. Also it would be great to be able to choose, which notifications should be used. Someone may for example not want to be notified for "polling started", or some only want to be notified for "polling failed". Although you making it possible to set priorities is already making this not a big problem. |
I'll think about it...you can already verify your notification servers are at least reachable by checking the logs at startup. MS attempts to contact the servers on known version/health endpoints and will log an error or success based on that.
Will also think on filtering notification types. |
Based on #65
[ ] Implement a healthcheck endpoint to monitor status (running/idle) of sources/clients
[ ] Integrate discord webhook or something like pusher webhook to allow notifications when health changes for sources/clients
The text was updated successfully, but these errors were encountered: