ICU-22224 Fix undefine behavior in rbbi constructor #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the undefined behavior in the default RuleBasedBreakIterator constructor that was caused by referencing a member of a not-yet-constructed object.
7 tasks
FrankYFTang
added a commit
that referenced
this pull request
Sep 25, 2024
# This is the 1st commit message: ICU-22767 Fix GCC warning and turn warning to errors # This is the commit message #2: ICU-22716 use pre-existing task # This is the commit message #3: ICU-22716 Fix # This is the commit message #4: ICU-22716 Fix unitialization # This is the commit message unicode-org#5: Update icu4c/source/common/ushape.cpp Co-authored-by: Fredrik Roubert <fredrik@roubert.name> # This is the commit message unicode-org#6: ICU-22716 change macro # This is the commit message unicode-org#7: ICU-22716 Add document about the macro # This is the commit message unicode-org#8: ICU-22716 Addres review feedback
FrankYFTang
added a commit
that referenced
this pull request
Sep 25, 2024
# This is the 1st commit message: ICU-22767 Fix GCC warning and turn warning to errors # This is the commit message #2: ICU-22716 use pre-existing task # This is the commit message #3: ICU-22716 Fix # This is the commit message #4: ICU-22716 Fix unitialization # This is the commit message unicode-org#5: Update icu4c/source/common/ushape.cpp Co-authored-by: Fredrik Roubert <fredrik@roubert.name> # This is the commit message unicode-org#6: ICU-22716 change macro # This is the commit message unicode-org#7: ICU-22716 Add document about the macro # This is the commit message unicode-org#8: ICU-22716 Addres review feedback # This is the commit message unicode-org#9: ICU-22767 Fix GCC warning and turn warning to errors # This is the commit message unicode-org#10: ICU-22716 use pre-existing task # This is the commit message unicode-org#11: ICU-22716 Fix # This is the commit message unicode-org#12: ICU-22716 Fix unitialization # This is the commit message unicode-org#13: Update icu4c/source/common/ushape.cpp Co-authored-by: Fredrik Roubert <fredrik@roubert.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the undefined behavior in the default RuleBasedBreakIterator constructor that was caused by referencing a member of a not-yet-constructed object.
Checklist