Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-13138 WIN64: fix ICU data binary naming for builds with Static layout #5

Closed
wants to merge 2 commits into from
Closed

ICU-13138 WIN64: fix ICU data binary naming for builds with Static layout #5

wants to merge 2 commits into from

Conversation

sav-ix
Copy link
Contributor

@sav-ix sav-ix commented Jul 5, 2018 •
edited by srl295
Loading

sav-ix added 2 commits July 5, 2018 10:03
@sav-ix
mingw-w64: add lib prefix to Static Data binary name
41ad0e0 
For builds using mingw-w64 with Static layout, missing 'lib'
prefix in ICU Data binary name leads to Stubdata binary use
during ICU extras, samples and tests build. ICU Stubdata
binary also substitutes Data in installation directory.

The above leads to runtime errors of ICU tools, tests and
ICU-based software.

Thus need to add 'lib' prefix to ICU Data binary name during
Pkgdata run.

Task-number: ICU-13138
Task-number: ICU-13187
@sav-ix
WIN64: do not create symlink to Static ICU Data binary
9f82400 
For builds using mingw-w64 and MSVC with Static layout,
ICU installation folder contains '.dll' file, which is
a symbolic link to '.a' or '.lib' Data binary.

This have no sense, since it can't be used as binary
with shared layout.

Task-number: ICU-13138
@sav-ix sav-ix changed the title mingw-w64: add lib prefix to Static Data binary name WIN64: fix ICU data binary naming for builds with Static layout Jul 5, 2018
@srl295 srl295 changed the title WIN64: fix ICU data binary naming for builds with Static layout ICU-13138 WIN64: fix ICU data binary naming for builds with Static layout Jul 18, 2018
srl295
srl295 requested changes Jul 18, 2018
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase on master. this will also cause automated builds to happen.

@sav-ix sav-ix mentioned this pull request Aug 5, 2018
Merged
@sav-ix
Copy link
Contributor Author

sav-ix commented Aug 5, 2018

Closed in favor of PR #44.

@sav-ix sav-ix closed this Aug 5, 2018
younies referenced this pull request in younies/icu Aug 8, 2019
@sven-oly
Merge pull request #5 from younies/craigmonkeytest
7981f6e 
Make the monkey test output nicer
hugovdm referenced this pull request in hugovdm/icu Jan 17, 2020
@sffc
Merge pull request #5 from hugovdm/units-sample-unittxt
9b3ca66 
CLDR-13488: Samples of intermediate source/data/misc/units.txt
hugovdm referenced this pull request in hugovdm/icu Mar 20, 2020
@younies
Merge pull request #5 from hugovdm/younies-units_router-convert
3cc9709 
Hook up data-driven unit conversion tests
hugovdm referenced this pull request in hugovdm/icu Jul 21, 2020
@hugovdm
Merge pull request #5 from hugovdm/usage_glue
08132e7 
Implement Usage "Glue Code"
GerHobbelt pushed a commit to GerHobbelt/icu that referenced this pull request Mar 11, 2024
@cwarner-8702
Merge pull request unicode-org#5 from Esri/chri8702/basic_conversions
477c0d0 
config: support basic character conversions
FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Sep 25, 2024
@FrankYFTang
# This is a combination of 8 commits.
66e35bf 
# This is the 1st commit message:

ICU-22767 Fix GCC warning and turn warning to errors

# This is the commit message #2:

ICU-22716 use pre-existing task

# This is the commit message #3:

ICU-22716 Fix

# This is the commit message #4:

ICU-22716 Fix unitialization

# This is the commit message unicode-org#5:

Update icu4c/source/common/ushape.cpp

Co-authored-by: Fredrik Roubert <fredrik@roubert.name>
# This is the commit message unicode-org#6:

ICU-22716 change macro

# This is the commit message unicode-org#7:

ICU-22716 Add document about the macro

# This is the commit message unicode-org#8:

ICU-22716 Addres review feedback
FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Sep 25, 2024
@FrankYFTang @roubert
# This is a combination of 13 commits.
35a1b16 
# This is the 1st commit message:

ICU-22767 Fix GCC warning and turn warning to errors

# This is the commit message #2:

ICU-22716 use pre-existing task

# This is the commit message #3:

ICU-22716 Fix

# This is the commit message #4:

ICU-22716 Fix unitialization

# This is the commit message unicode-org#5:

Update icu4c/source/common/ushape.cpp

Co-authored-by: Fredrik Roubert <fredrik@roubert.name>
# This is the commit message unicode-org#6:

ICU-22716 change macro

# This is the commit message unicode-org#7:

ICU-22716 Add document about the macro

# This is the commit message unicode-org#8:

ICU-22716 Addres review feedback

# This is the commit message unicode-org#9:

ICU-22767 Fix GCC warning and turn warning to errors

# This is the commit message unicode-org#10:

ICU-22716 use pre-existing task

# This is the commit message unicode-org#11:

ICU-22716 Fix

# This is the commit message unicode-org#12:

ICU-22716 Fix unitialization

# This is the commit message unicode-org#13:

Update icu4c/source/common/ushape.cpp

Co-authored-by: Fredrik Roubert <fredrik@roubert.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sav-ix @srl295