Group filter and Git detection #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frederick888
force-pushed
the
group-detect
branch
2 times, most recently
from
8efbda4 to
b06e8f4
Compare
Frederick888
force-pushed
the
group-detect
branch
from
b06e8f4 to
e8c9877
Compare
When Git is requesting an HTTP/S credential, by default only return entries from the dedicated group configured by `git-credential-keepassxc configure`. This can be disabled by `--no-git-detection`. Note since KeePassXC returns no database info here, group names configured for all databases are used regardless of where an entry is from. So it's better to simply use the same dedicated group name across the board (by default this is 'Git'). Also implements `--group`. This option overrides Git detection. Requires KeePassXC >= 2.6.0 [1]. [1] keepassxreboot/keepassxc#4111
Allow using --no-filter/--no-git-detection/--group in front of get/store. This can come handy if someone wants to use them in .gitconfig, as Git places these options in front of subcommands and there is no longer a need to write a custom wrapper. Note conflicts_with = "<subcommand option>" does not work when using these filter options at global position.
Frederick888
force-pushed
the
group-detect
branch
from
e8c9877 to
5dfdde1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #50
Detect Git HTTP operations (mainly fetch/push over HTTP/S) and use
entries from git-credentials-keepassxc group (configured during
git-credentials-keepassxc configure, by defaultGit).Also offers a
--group xyzoption for get/set.Changes
7065583refactor: Move GitCredentialMessage ops to impl296efdefeat(get,store)!: Group filter from CLI or Git detectionWhen Git is requesting an HTTP/S credential, by default only return
entries from the dedicated group configured by
git-credential-keepassxc configure. This can be disabled by--no-git-detection.Note since KeePassXC returns no database info here, group names
configured for all databases are used regardless of where an entry is
from. So it's better to simply use the same dedicated group name across
the board (by default this is 'Git').
Also implements
--group. This option overrides Git detection.Requires KeePassXC >= 2.6.0 [1].
[1] keepassxreboot/keepassxc#4111
5dfdde1feat(get,store): Global filter optionsAllow using --no-filter/--no-git-detection/--group in front of
get/store. This can come handy if someone wants to use them in
.gitconfig, as Git places these options in front of subcommands and
there is no longer a need to write a custom wrapper.
Note conflicts_with = "" does not work when using
these filter options at global position.
Checklist
Is this a breaking change?
Yes. If someone's been using a credential from other groups for such
operations, it'll break cos we now return from the dedicated group only
by default.