Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the name of the group to the results for browser extensions #4111

Merged
merged 1 commit into from
Mar 7, 2020
Merged

Add the name of the group to the results for browser extensions #4111

merged 1 commit into from
Mar 7, 2020

Conversation

ulich
Copy link
Contributor

@ulich ulich commented Jan 6, 2020 •
edited
Loading

So it can be displayed in the autocomplete list when more than one login matches.

Type of change

  • ✅ New feature (non-breaking change which adds functionality)

Description and Context

For users that use groups and have similar names for multiple logins but they are organized in different groups.

Fixes keepassxreboot/keepassxc-browser#466 together with keepassxreboot/keepassxc-browser#739

Testing strategy

Create multiple entries for the same URL in different groups.
Use the browser extension with the changes from keepassxreboot/keepassxc-browser#739.
I also tested edge cases

  • Older KeepassXC version without this change: Browser extension still works
  • All entries being in the same group

I am not sure if the group can be null. Is it safe like this? At least I wasn't able to create a database without groups.

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@ulich ulich mentioned this pull request Jan 6, 2020
Merged
@droidmonkey droidmonkey added this to the v2.6.0 milestone Jan 16, 2020
@ulich ulich force-pushed the groupname branch 2 times, most recently from c975a8e to 5d493b2 Compare February 20, 2020 20:25
@ulich
Copy link
Contributor Author

ulich commented Feb 21, 2020

keepassxreboot/keepassxc-browser#739 has been merged. This is now only a minor thing. Could you please have a look?

@ulich @droidmonkey
Add the name of the group to the results for browser extensions
89aa7ae 
Fixes keepassxreboot#466

So it can be displayed in the autocomplete list when more than
one login matches. For users that use groups and have similar names
for multiple logins but organized in different groups
@droidmonkey droidmonkey merged commit a6c3c11 into keepassxreboot:develop Mar 7, 2020
droidmonkey added a commit that referenced this pull request Jul 7, 2020
@droidmonkey
Release 2.6.0
0765954 
Added

- Custom Light and Dark themes [#4110, #4769, #4791, #4796, #4892, #4915]
- Compact mode to use classic Group and Entry line height [#4910]
- View menu to quickly switch themes, compact mode, and toggle UI elements [#4910]
- Search for groups and scope search to matched groups [#4705]
- Save Database Backup feature [#4550]
- Sort entries by "natural order" and move lines up/down [#4357]
- Option to launch KeePassXC on system startup/login [#4675]
- Caps Lock warning on password input fields [#3646]
- Add "Size" column to entry view [#4588]
- Browser-like tab experience using Ctrl+[Num] (Alt+[Num] on Linux) [#4063, #4305]
- Password Generator: Define additional characters to choose from [#3876]
- Reports: Database password health check (offline) [#3993]
- Reports: HIBP online service to check for breached passwords [#4438]
- Auto-Type: DateTime placeholders [#4409]
- Browser: Show group name in results sent to browser extension [#4111]
- Browser: Ability to define a custom browser location (macOS and Linux only) [#4148]
- Browser: Ability to change root group UUID and inline edit connection ID [#4315, #4591]
- CLI: `db-info` command [#4231]
- CLI: Use wl-clipboard if xclip is not available (Linux) [#4323]
- CLI: Incorporate xclip into snap builds [#4697]
- SSH Agent: Key file path env substitution, SSH_AUTH_SOCK override, and connection test [#3769, #3801, #4545]
- SSH Agent: Context menu actions to add/remove keys [#4290]

Changed

- Complete replacement of default database icons [#4699]
- Complete replacement of application icons [#4066, #4161, #4203, #4411]
- Complete rewrite of documentation and manpages using Asciidoctor [#4937]
- Complete refactor of config files; separate between local and roaming [#4665]
- Complete refactor of browser integration and proxy code [#4680]
- Complete refactor of hardware key integration (YubiKey and OnlyKey) [#4584, #4843]
- Significantly improve performance when saving and opening databases [#4309, #4833]
- Remove read-only detection for database files [#4508]
- Overhaul of password fields and password generator [#4367]
- Replace instances of "Master Key" with "Database Credentials" [#4929]
- Change settings checkboxes to positive phrasing for consistency [#4715]
- Improve UX of using entry actions (focus fix) [#3893]
- Set expiration time to Now when enabling entry expiration [#4406]
- Always show "New Entry" in context menu [#4617]
- Issue warning before adding large attachments [#4651]
- Improve importing OPVault [#4630]
- Improve AutoOpen capability [#3901, #4752]
- Check for updates every 7 days even while still running [#4752]
- Improve Windows installer UI/UX [#4675]
- Improve config file handling of portable distribution [#4131, #4752]
- macOS: Hide dock icon when application is hidden to tray [#4782]
- Browser: Use unlock dialog to improve UX of opening a locked database [#3698]
- Browser: Improve database and entry settings experience [#4392, #4591]
- Browser: Improve confirm access dialog [#2143, #4660]
- KeeShare: Improve monitoring file changes of shares [#4720]
- CLI: Rename `create` command to `db-create` [#4231]
- CLI: Cleanup `db-create` options (`--set-key-file` and `--set-password`) [#4313]
- CLI: Use stderr for help text and password prompts [#4086, #4623]
- FdoSecrets: Display existing secret service process [#4128]

Fixed

- Fix changing focus around the main window using tab key [#4641]
- Fix search field clearing while still using the application [#4368]
- Improve search help widget displaying on macOS and Linux [#4236]
- Return keyboard focus after editing an entry [#4287]
- Reset database path after failed "Save As" [#4526]
- Use SHA256 Digest for Windows code signing [#4129]
- Improve handling of ccache when building [#4104, #4335]
- macOS: Properly re-hide application window after browser integration and Auto-Type usage [#4909]
- Auto-Type: Fix crash when performing on new entry [#4132]
- Browser: Send legacy HTTP settings to recycle bin [#4589]
- Browser: Fix merging browser keys [#4685]
- CLI: Fix encoding when exporting database [#3921]
- SSH Agent: Improve reliability and underlying code [#3833, #4256, #4549, #4595]
- FdoSecrets: Fix crash when editing settings before service is enabled [#4332]
Frederick888 added a commit to Frederick888/git-credential-keepassxc that referenced this pull request Oct 3, 2022
@Frederick888
feat(get,store)!: Group filter from CLI or Git detection
1ff72ee 
When Git is requesting an HTTP/S credential, by default only return
entries from the dedicated group configured by `git-credential-keepassxc
configure`. This can be disabled by `--no-git-detection`.

Note since KeePassXC returns no database info here, group names
configured for all databases are used regardless of where an entry is
from. So it's better to simply use the same dedicated group name across
the board (by default this is 'Git').

Also implements `--group`. This option overrides Git detection.

Requires KeePassXC >= 2.6.0 [1].

[1] keepassxreboot/keepassxc#4111
@github-actions github-actions bot mentioned this pull request Oct 3, 2022
Closed
3 tasks
Frederick888 added a commit to Frederick888/git-credential-keepassxc that referenced this pull request Oct 14, 2022
@Frederick888
feat(get,store)!: Group filter from CLI or Git detection
dfde378 
When Git is requesting an HTTP/S credential, by default only return
entries from the dedicated group configured by `git-credential-keepassxc
configure`. This can be disabled by `--no-git-detection`.

Note since KeePassXC returns no database info here, group names
configured for all databases are used regardless of where an entry is
from. So it's better to simply use the same dedicated group name across
the board (by default this is 'Git').

Also implements `--group`. This option overrides Git detection.

Requires KeePassXC >= 2.6.0 [1].

[1] keepassxreboot/keepassxc#4111
Frederick888 added a commit to Frederick888/git-credential-keepassxc that referenced this pull request Jan 27, 2023
@Frederick888
feat(get,store)!: Group filter from CLI or Git detection
296efde 
When Git is requesting an HTTP/S credential, by default only return
entries from the dedicated group configured by `git-credential-keepassxc
configure`. This can be disabled by `--no-git-detection`.

Note since KeePassXC returns no database info here, group names
configured for all databases are used regardless of where an entry is
from. So it's better to simply use the same dedicated group name across
the board (by default this is 'Git').

Also implements `--group`. This option overrides Git detection.

Requires KeePassXC >= 2.6.0 [1].

[1] keepassxreboot/keepassxc#4111
Frederick888 added a commit to Frederick888/git-credential-keepassxc that referenced this pull request Jan 27, 2023
@Frederick888
feat(get,store): Group filter --group and --git-groups
523063b 
Filter login entries by group names provided by --group option. This
option can be repeated.

Since the store operation consists of getting existing entries then
update or create an entry, this option also applies to store. One minor
difference from get is that when a new entry needs to be created,
--group options at the global position are ignored, i.e. it uses the
local --group if it's present, or the dedicated group created by
git-credential-keepassxc configure.

Also a new --git-groups option is added to filter login entries using
the names of the dedicated groups. Note that it filters all entries by
all groups from all databases, which can lead to unexpected results if a
user has more than one databases with different dedicated group names.
This is a limitation from KeePassXC as we don't get database UUIDs here.

Requires KeePassXC >= 2.6.0 [1].

[1] keepassxreboot/keepassxc#4111
Frederick888 added a commit to Frederick888/git-credential-keepassxc that referenced this pull request Jan 27, 2023
@Frederick888
feat(get,store): Group filter --group and --git-groups
9fe7479 
Filter login entries by group names provided by --group option. This
option can be repeated.

Since the store operation consists of getting existing entries then
update or create an entry, this option also applies to store. One minor
difference from get is that when a new entry needs to be created,
--group options at the global position are ignored, i.e. it uses the
local --group if it's present, or the dedicated group created by
git-credential-keepassxc configure.

Also a new --git-groups option is added to filter login entries using
the names of the dedicated groups. Note that it filters all entries by
all groups from all databases, which can lead to unexpected results if a
user has more than one databases with different dedicated group names.
This is a limitation from KeePassXC as we don't get database UUIDs here.

Requires KeePassXC >= 2.6.0 [1].

[1] keepassxreboot/keepassxc#4111
Frederick888 added a commit to Frederick888/git-credential-keepassxc that referenced this pull request Jan 27, 2023
@Frederick888
feat(get,store): Group filter --group and --git-groups
1269108 
Filter login entries by group names provided by --group option. This
option can be repeated.

Since the store operation consists of getting existing entries then
update or create an entry, this option also applies to store. One minor
difference from get is that when a new entry is created, --group options
at the global position are ignored, i.e. it uses the first local --group
option if it's present, or the dedicated group created by
git-credential-keepassxc configure.

Also a new --git-groups option is added to filter login entries using
the names of the dedicated groups. Note that it filters all entries by
all groups from all databases, which can lead to unexpected results if a
user has more than one databases with different dedicated group names.
This is a limitation from KeePassXC as we don't get database UUIDs here.

Requires KeePassXC >= 2.6.0 [1].

[1] keepassxreboot/keepassxc#4111
Frederick888 added a commit to Frederick888/git-credential-keepassxc that referenced this pull request Jan 27, 2023
@Frederick888
feat(get,store): Group filter --group and --git-groups
621813e 
Filter login entries by group names provided by --group option. This
option can be repeated.

Since the store operation consists of getting existing entries then
update or create an entry, this option also applies to store. One minor
difference from get is that when a new entry is created, --group options
at the global position are ignored, i.e. it uses the first local --group
option if it's present, or the dedicated group created by
git-credential-keepassxc configure.

Also a new --git-groups option is added to filter login entries using
the names of the dedicated groups. Note that it filters all entries by
all groups from all databases, which can lead to unexpected results if a
user has more than one databases with different dedicated group names.
This is a limitation from KeePassXC as we don't get database UUIDs here.

Requires KeePassXC >= 2.6.0 [1].

[1] keepassxreboot/keepassxc#4111
Frederick888 added a commit to Frederick888/git-credential-keepassxc that referenced this pull request Jan 27, 2023
@Frederick888
feat(get,totp,store): Group filter --group and --git-groups
0ed5213 
Filter login entries by group names provided by --group option. This
option can be repeated.

Since the store operation consists of getting existing entries then
update or create an entry, this option also applies to store. One minor
difference from get is that when a new entry is created, --group options
at the global position are ignored, i.e. it uses the first local --group
option if it's present, or the dedicated group created by
git-credential-keepassxc configure.

Also a new --git-groups option is added to filter login entries using
the names of the dedicated groups. Note that it filters all entries by
all groups from all databases, which can lead to unexpected results if a
user has more than one databases with different dedicated group names.
This is a limitation from KeePassXC as we don't get database UUIDs here.

Requires KeePassXC >= 2.6.0 [1].

[1] keepassxreboot/keepassxc#4111
Frederick888 added a commit to Frederick888/git-credential-keepassxc that referenced this pull request Jan 27, 2023
@Frederick888
feat(get,totp,store): Group filter --group and --git-groups
4e3c877 
Filter login entries by group names provided by --group option. This
option can be repeated.

Since the store operation consists of getting existing entries then
update or create an entry, this option also applies to store. One minor
difference from get is that when a new entry is created, --group options
at the global position are ignored, i.e. it uses the first local --group
option if it's present, or the dedicated group created by
git-credential-keepassxc configure.

Also a new --git-groups option is added to filter login entries using
the names of the dedicated groups. Note that it filters all entries by
all groups from all databases, which can lead to unexpected results if a
user has more than one databases with different dedicated group names.
This is a limitation from KeePassXC as we don't get database UUIDs here.

Requires KeePassXC >= 2.6.0 [1].

[1] keepassxreboot/keepassxc#4111
@github-actions github-actions bot mentioned this pull request Jan 27, 2023
Merged
3 tasks
Frederick888 added a commit to Frederick888/git-credential-keepassxc that referenced this pull request Jan 27, 2023
@Frederick888
feat(get,totp,store): Group filter --group and --git-groups
233da53 
Filter login entries by group names provided by --group option. This
option can be repeated.

Since the store operation consists of getting existing entries then
update or create an entry, this option also applies to store. One minor
difference from get is that when a new entry is created, --group options
at the global position are ignored, i.e. it uses the first local --group
option if it's present, or the dedicated group created by
git-credential-keepassxc configure.

Also a new --git-groups option is added to filter login entries using
the names of the dedicated groups. Note that it filters all entries by
all groups from all databases, which can lead to unexpected results if a
user has more than one databases with different dedicated group names.
This is a limitation from KeePassXC as we don't get database UUIDs here.

Requires KeePassXC >= 2.6.0 [1].

[1] keepassxreboot/keepassxc#4111
Frederick888 added a commit to Frederick888/git-credential-keepassxc that referenced this pull request Jan 27, 2023
@Frederick888
feat(get,totp,store): Group filter --group and --git-groups
5da3225 
Filter login entries by group names provided by --group option. This
option can be repeated.

Since the store operation consists of getting existing entries then
update or create an entry, this option also applies to store. One minor
difference from get is that when a new entry is created, --group options
at the global position are ignored, i.e. it uses the first local --group
option if it's present, or the dedicated group created by
git-credential-keepassxc configure.

Also a new --git-groups option is added to filter login entries using
the names of the dedicated groups. Note that it filters all entries by
all groups from all databases, which can lead to unexpected results if a
user has more than one databases with different dedicated group names.
This is a limitation from KeePassXC as we don't get database UUIDs here.

Requires KeePassXC >= 2.6.0 [1].

[1] keepassxreboot/keepassxc#4111
Frederick888 added a commit to Frederick888/git-credential-keepassxc that referenced this pull request Jan 27, 2023
@Frederick888
feat(get,totp,store): Group filter --group and --git-groups
d33e1ec 
Filter login entries by group names provided by --group option. This
option can be repeated.

Since the store operation consists of getting existing entries then
update or create an entry, this option also applies to store. One minor
difference from get is that when a new entry is created, --group options
at the global position are ignored, i.e. it uses the first local --group
option if it's present, or the dedicated group created by
git-credential-keepassxc configure.

Also a new --git-groups option is added to filter login entries using
the names of the dedicated groups. Note that it filters all entries by
all groups from all databases, which can lead to unexpected results if a
user has more than one databases with different dedicated group names.
This is a limitation from KeePassXC as we don't get database UUIDs here.

Requires KeePassXC >= 2.6.0 [1]. These two options are ignored if used
with any older KeePassXC.

[1] keepassxreboot/keepassxc#4111
@phoerious phoerious added the pr: new feature Pull request that adds a new feature label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droidmonkey droidmonkey droidmonkey approved these changes

@varjolintu varjolintu varjolintu approved these changes

Assignees
No one assigned
Labels
feature: Browser pr: new feature Pull request that adds a new feature
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.

Folder option for autocomplete
4 participants
@ulich @droidmonkey @varjolintu @phoerious