Enable browser-like DbTab experience (Alt + Nums)

[JulianVolodia]

1-9 goes to 1-9 tab; 0 - goes to the last one

Please read Testing strategy, thanks!

Type of change

• ✅ New feature (non-breaking change which adds functionality)

Description and Context

In browsers we could not only use CTRL + PgDn/PgUp and CTRL (+ SHIFT) + TAB to switch tabs.
There is also ALT + which have various types of work. 1-9 operates on tabs from 1st to 9th one, and (on Chrome?) the 0 goes to last one.
On the another similar to KPXC application found this kind of feature. ;)

Screenshots

N/A

Testing strategy

This is WIP, I wonder if this code could be (bc of less complexity) or should change to functor or some Signal mapper.

Checklist:

• ✅ I have read the CONTRIBUTING document. [REQUIRED]
• ✅ My code follows the code style of this project. [REQUIRED]
• ✅ All new and existing tests passed. [REQUIRED]
• ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  Not yet: - ✅ My change requires a change to the documentation, and I have updated it accordingly.
  Not yet: - ✅ I have added tests to cover my changes.

[droidmonkey]

1. This should be a keyboard shortcut assigned within the DatabaseTabWidget.

2. You can use the modern Signal/Slot call methods using lambda functions:

auto shortcut = QShortcut(Qt::Alt + Qt::Key_1, this);
connect(shortcut, SIGNAL(activated()), this, [this] { selectDatabaseTab(1); });

[JulianVolodia]

1. This should be a keyboard shortcut assigned within the DatabaseTabWidget.

2. You can use the modern Signal/Slot call methods using lambda functions:

auto shortcut = QShortcut(Qt::Alt + Qt::Key_1, this);
connect(shortcut, SIGNAL(activated()), this, [this] { selectDatabaseTab(1); });

Thanks for your response. I will change PR in next day. Best

[JulianVolodia]

1. This should be a keyboard shortcut assigned within the DatabaseTabWidget.

@droidmonkey, I don't see any QShortcuts in there.
Also, MainWindow has shortcuts for other Db shortcuts stuff there. Does it needs refactor indeed?

[droidmonkey]

Arguably those shortcuts are also misplaced. The DB tab widget directly controls which tab is selected so it makes way more sense to have it bind the keyboard shortcut. I wouldn't mind the other tab controlling shortcuts to move as well.

[droidmonkey]

I made the necessary changes, ready for merge.

[JulianVolodia]

Thanks, sorry for not getting this done first and then refactoring. I will try to do it in one month (the refactor you mentioned, in nice commits as logic parts). śr., 22 sty 2020 o 00:35 Jonathan White <notifications@github.com> napisał(a):

…

I made the necessary changes, ready for merge. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4063?email_source=notifications&email_token=AAJJTTY54EM5AJHNUBC4ODTQ66BD5A5CNFSM4J7PUJRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJRV3BI#issuecomment-576937349>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJJTT26LRXADYJKGL6PHBLQ66BD5ANCNFSM4J7PUJRA> .

[droidmonkey]

Oh its all done

[JulianVolodia]

<3 Sorry for not helping You more. Thank you. czw., 23 sty 2020 o 15:21 Jonathan White <notifications@github.com> napisał(a):

…

Oh its all done

[JulianVolodia]

Arguably those shortcuts are also misplaced. The DB tab widget directly controls which tab is selected so it makes way more sense to have it bind the keyboard shortcut. I wouldn't mind the other tab controlling shortcuts to move as well.

I was mentioning this, about changing other. I will look if I catch sth up or if could help with something other.

Appreciate your work, thank You for what you are doing for us, @droidmonkey

[droidmonkey]

So I tried moving the shortcut commands and realized if you do that then they only work when the tabs have explicit focus which is not desirable. So moved back to MainWindow

[JulianVolodia]

So I tried moving the shortcut commands and realized if you do that then they only work when the tabs have explicit focus which is not desirable. So moved back to MainWindow

Great! I now understand it completely, that seems familiar with what I was thinking about during stub of change. Thanks that you fixed it.

I hope I will give you more help in future, because that tool is avvesome and and want to move from KeePassX https://keepass.info/ KeePass completely.

Happy hacking!

[varjolintu]

This breaks the possibility to write @ char on macOS, because the shortcut for that is Alt+2. So any attempt to write, for example, an email address manually to an entry always switches to a second database.

[droidmonkey]

@varjolintu is it not possible to enter an '@' using Shift+2? Is this due to an non-US keyboard? Before I disable this feature on macOS, need to understand how widespread the issue actually is.

[varjolintu]

@droidmonkey non-US keyboard layout, yes. Shift+2 gives " for Finnish. I need to lookup the whole layout table somewhere and see which one are affected.

[JulianVolodia]

Hey @varjolintu could you tell me what ⌘Command + 0 does on your MacOS with browser with 13 or more tabs?
I checked that MacOS should have behaviour like that in browser but using ⌘Command + NumLine keys. Could you tell me that this is OK and do not collide with anything on MacOS?
ref: https://www.wikihow.com/Switch-Tabs-in-Chrome

with regards to https://www.idownloadblog.com/2017/05/15/keyboard-shortcut-switch-safari-tabs/ on MacOS: **

1. Hold Shift+⌘Command and press the right or left arrow key. (...to go to next/prev tab in browser) **
2. Control+Tab or Control+Shift+Tab to cycle through your tabs. (...same as (1) )
3. Hold down ⌘Command + press 1-9 on your numeric keypad. The numbers on your keypad will correspond with the order and count of the tabs currently active.

Same from 1-2 above in 3-4 said here - no reference about NumLine https://www.quora.com/Is-there-a-shortcut-key-for-switching-between-tabs-in-Chrome-for-Mac/answer/Chris-Chovanek :

1. Command + Tab = switch between applications.
2. Command + ~ = switch between windows of an application. **
3. CTRL + Tab = move forward through tabs (in same window)
4. CTRL + Shift + Tab = move backward through tabs (in same window)

On Linux:
On Linux, Firefox and Chromium, on both PL and US keyboard switch tabs when used combination:

• LeftAlt + NumLine
• LeftCtrl + NumLine
• RightCtrl + NumLine

For RightAlt + NumLine works as above only on US kb laybout. On PL produces additional characters.

Dear @varjolintu I've checked Linux with Finnish by setxkbmap fi and (RightAlt) AltGr + 2 produces @ but (LeftAlt) Alt works as the same as for US kb layout

Dear @droidmonkey maybe there is another general 'ModX' key in Qt introducted to have this working across platforms and kb layouts? I have a glance on it but not found it.

[varjolintu]

@JulianVolodia ⌘Command + 0 does nothing with Chromium or Firefox. The issue is not using ⌘Command+2 but ⌥Alt+2.

[varjolintu]

The same ⌥Alt+2 for writing @ applies to following keyboard layouts on macOS:
Ainu, Belarusian, Croatian, Czech, Estonian, Finnish, Icelandic, Khmer, Pashto, Persian, Polish, Russian, Slovak, Ukrainian, Uzbek and Vietnamese.

[JulianVolodia]

@JulianVolodia ⌘Command + 0 does nothing with Chromium or Firefox. The issue is not using ⌘Command+2 but ⌥Alt+2.

I am asking you because:

• I don't have hackintosh on currently using notebook with limited resources and can't reproduce behaviour with good UX for MacOS users

I understand because that is a glitch. Change introduce Alt + NumLine as I proposed and @droidmonkey prepared change, but I missed completely testing on MacOS - so I want to repair my mistake.

That is why I asking that. On MacOS there should be only using Command as you said. But @varjolintu please tell me how Chrome or Firefox behave on your system, or actually what is more natural for MacOS user. Thanks in advance and sorry for inconvenience.

PS to C + 0 --> good, and Command + 9? does it go to last tab in them, or to nineth of them?

[varjolintu]

@JulianVolodia I understand. This happens with my desktop with Apple Keyboard. Also with my old MacBook Pro.

And I agree using the ⌘Command with macOS would be far better, because it seems to switch tabs with both Chromium and Firefox (so that must be the standard way to do it). Just the ⌘Command+0 doesn't switch to the tenth tab. It does't do anything.

It's common that with non-US keyboard layouts, the tab switching always happens with CTRL+Tab and CTRL+Shift+Tab. Sadly, I haven't been able to get that to work with macOS and Qt.

[JulianVolodia]

@varjolintu wait a moment. Everything is allright on your side. Only bleeding-edge KeepassXC have infroduced bug because of me.

And I agree using the ⌘Command with macOS would be far better, because it seems to switch tabs with both Chromium and Firefox (so that must be the standard way to do it). Just the ⌘Command+0 doesn't switch to the tenth tab. It does't do anything.

On Chomium/Firefox on Linux also does nothing. I must mix something up when reporting, or recheck on Windows.
On Firefox@Linux works only with (Left)Alt+NumLine. On Chrome works both with Ctrl and (L)Alt.
1-8 goes to tabs, and 9 to last one, of all.

It's common that with non-US keyboard layouts, the tab switching always happens with CTRL+Tab and CTRL+Shift+Tab. Sadly, I haven't been able to get that to work with macOS and Qt.

Um.... that's strange. Have you used on MacOS, Qt.Key s:
Key_Control as Command keys, and
Key_Meta as Control keys ?

Could you try to change locally and post feedback?

[varjolintu]

@JulianVolodia I made a new PR for it: #4305

[JulianVolodia]

I must check why (different on Windows?) I proposed combo with 0 to go to last not 9.

On Linux and MacOS this is 9, which activate last one.

[JulianVolodia]

@varjolintu I checked your commit and 👍 because as I faith you tested it should fix @ character on MacOS but 👎 because you said that cmmnd + 0 do nothing but coded the behaviour of cmmnd + 9.

[varjolintu]

@JulianVolodia With KeePassXC ⌘Command+0 changes to last selected tab, as it is coded. What you asked was what it does with browsers. As I said, nothing happens with Chromium and Firefox.

I don't see any reason why ⌘Command+0 would be changed to ⌘Command+9 in KeePassXC.

EDIT: I was wrong. See below.

[JulianVolodia]

Have you read my comment? I don't know why I proposed 0 as last. 9 should go because UX of 80% users who use browser (most commonly used SW these days...) will look for cmd+9 not what you coded, is it clear now @varjolintu ?

[JulianVolodia]

And, as I mentioned there should go fix on Linux and I must check on windows but I dont have any other than Linux box near me under control. Cheers.

@droidmonkey could we change it once again?

[varjolintu]

@JulianVolodia Sorry. Missed that. You are absolutely correct. 9 goes to the last tab with any browser.

[JulianVolodia]

@JulianVolodia Sorry. Missed that. You are absolutely correct. 9 goes to the last tab with any browser.

If you say so, I am sure now @varjolintu there is another bug I introducted in the very first place that missed (and cannot check now) if on Windows there is same as on MacOS/Linux and 0 was another mistake.

I just want to return your full support for KB but other users on Mac could like this 9'combo as on browser. I hope we are good now. Cheers

[JulianVolodia]

@varjolintu said in #4305 :

@JulianVolodia I could've done any necessary fixes in this PR. Also, your new PR seems to break things.

Which things? BTW. in general that was rude imho, but maybe I am wrong. If you could, I hope you will tell me what things are broken and why you said that.

@varjolintu commented on change https://github.com/keepassxreboot/keepassxc/pull/4306/files/c66ad4144381e614e8c2ff62a6a817167f0eecf0 :

Now you are keeping CTRL+9 shortcut alive even with WIndows systems. Why did you remove the previous ifdef?

Have you read commit message before commenting? I described why it is there. Also, see #4063 (comment) because there is reference that Windows also have this feature working as on Linux.

Your commit does the same thing for Windows, but silently because on Windows MacOS preprocessor constant is not definied. I hope you made mistake in comment.

So, to be verbose and clear:

• your ⌘Command combination works on MacOS as combo with Qt::CTRL (block w/o if clauses)
• mine Linux and Windows boxes have combinations using their Control a.k.a. Qt::CTRL and that above is reused code for that case.
• Linux and Windows but not MacOS (block with if clause) have also shortcut with Qt::ALT a.k.a (Left) Alt not (Right Alt|AltGr) - that will be added only on Windows and Unix but not on AIX. Best is to if clause the code verbosely but there is IMHO no chance to introduction of KeePassXC on AIX i.e. so no need to adding additional block.
  Defining explicitly, that you want this and not that is IMHO better than ELSE'ing some blocks.

Check full git diff against the develop from HEAD of that PR to see that it is more readable, when you remove 9 combo from end and change 0 to 9 combo. Easier to review, not 'hacked out' imho.

@droidmonkey should I delete my PR #4306 or you like it?

[varjolintu]

@JulianVolodia What I meant was this: your new PR modified the shortcuts in a way the CTRL+num are already activated on every system, plus it added ALT+num shortcuts on Windows and Linux as additional shortcuts. So both of those were active, and that's not something we want, is it?

I'm not quite sure what do you mean. The whole point was just to change MacOS to use CTRL instead of ALT.

If we want to use some different shortcuts on AIX, then it would be easiest to add #if defined(Q_OS_UNIX) && !defined(Q_OS_MACOS) define to the PR.

[ebneazad]

I m the one Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Sami Vänttinen <notifications@github.com> Sent: Sunday, February 9, 2020 8:09:01 PM To: keepassxreboot/keepassxc <keepassxc@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: Re: [keepassxreboot/keepassxc] Enable browser-like DbTab experience (Alt + Nums) (#4063) @JulianVolodia<https://github.com/JulianVolodia> What I meant was this: your new PR modified the shortcuts in a way the CTRL+num are already activated on every system, plus it added ALT+num shortcuts on Windows and Linux as additional shortcuts. So both of those were active, and that's not something we want, is it? I'm not quite sure what do you mean. The whole point was just to change MacOS to use CTRL instead of ALT. If we want to use some different shortcuts on AIX, then it would be easiest to add #if defined(Q_OS_UNIX) && !defined(Q_OS_MACOS) define to the PR. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#4063?email_source=notifications&email_token=AII4KW4CP6MV5AIHBWYVY2LRCAE73A5CNFSM4J7PUJRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELGNMJI#issuecomment-583849509>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AII4KW7ZWCOCPIGMKLHX6KLRCAE73ANCNFSM4J7PUJRA>.

[JulianVolodia]

@varjolintu OK, so I need more coffee when I writing to someone about UX I think.

Let's start (and hope that will be end and you will get my point):

@JulianVolodia What I meant was this: your new PR modified the shortcuts...

Yes, this change is about that.

...in a way the CTRL+num are already activated on every system, ...

No. Was not. Have you read my commit msg?
On MacOS users use Command + Numline on browsers which are Qt::CTRL + Num. As you informed (thanks again) 1-8 change active tab to one of following beginnig, and 9 warps us to last. That is what you want, because Alt is not for you (and all non-US ppl or US using weird aka nonstandard characters). I used your comment to do that and documentation. Checked 3 sources as you could find on posts above. or here https://www.twam.info/wp-content/uploads/2010/08/us_international.png

So with 0 and 9 was clearly the bug. All ppl use 9 to end and 1-8 to static first tabs. 0 not used. Clear now I hope. Same goes below.

Here goes rollercoaster:
On Windows and Linux

• (Left Alt aka Alt not Right/AltGr) + NumLine works in Mozilla (Thunderbird, Firefox, Chromium), and do described thing as I checked and you commited was left in your change Fix browser-like DbTab experience with macOS and Windows #4305 - good enought we say.
• here goes sth else: On Windows and Linux Qt::CTRL (left and right, this is the same key) is not Command key as on MacOS. It's Ctrl and in Chromium Ctrl+NumLine does same thing as Alt+NumLine. Thats why I added it.

plus it added ALT+num shortcuts on Windows and Linux as additional shortcuts. So both of those were active, and that's not something we want, is it?

As I described above, and tired you probably (I feel tired about that, this is pointless for me much more but not for UX case of some group of users - as they could say more of them use Chromium than are from Finland so could say that this change is more important not because non-US layout).

I'm not quite sure what do you mean. The whole point was just to change MacOS to use CTRL instead of ALT.

That was easier to code reuse if I understand correctly. Than Kopi-Pasten theorem applying with 3 blocks - just unneded.

If we want to use some different shortcuts on AIX, then it would be easiest to add #if defined(Q_OS_UNIX) && !defined(Q_OS_MACOS) define to the PR.

So, easiest for you refactoring it, as the code readed in first place or easier to implement now?

I got your point, maybe I am just out of doing it well because time passed and must more practice.

[varjolintu]

@JulianVolodia The PR is already updated so it would solve all the problems we have discovered.