Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DB_DIR placeholder for autoopen urls #3901

Merged

Conversation

stingray21
Copy link
Contributor

@stingray21 stingray21 commented Nov 19, 2019

Type of change

  • ✅ New feature (non-breaking change which adds functionality)

Description and Context

Add placeholder {DB_DIR} for the url of the autoopen functionality

Adding placeholder for the url of the autoopen functionality would it make easier to sync a database with a child database on multiple devices via file sharing services.

e.g. {DB_DIR}/passwords.kdbx

Currently relative paths and absolute paths work in KeepassXC (#1053).
But relative paths do not work in Keepass2 or other clients i.e Keepass2Android, whereas path placeholders work in those clients.

Keepass placeholders:
https://keepass.info/help/base/placeholders.html

Fixes #3863

Testing strategy

created databases linked them to the parent database, using different url styles (relative path, file:///, and with {DB_DIR})

built it with following settings:
cmake -DWITH_TESTS=ON -DWITH_ASAN=ON -DCMAKE_BUILD_TYPE=Release ..

I ran the make test and these tests failed (but I don't know what to do about it):
1 - testgroup (Failed)
15 - testopvaultreader (Failed)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
    see testing section
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@stingray21
Copy link
Contributor Author

I know that there are still some parts that definitely need to be changed. I tried to understand how the code works and to make the {DB_DIR} placeholder work to best of my knowledge (I'm still pretty new to C++ and this project).

  • I didn't understand what the if statement in the switch cases is supposed to check (e.g. if (placeholderType(url()) == PlaceholderType::Url)). Therefore I put a proxy statement that is always true.
  • I know that I am not supposed to declare variables within the switch statement, but I am unsure where to declare it. I thought it only needs to be declared in the DB_DIR case.
  • I changed entry->url() to entry->displayUrl(), otherwise the path would be replaced in the gui but the child databases do not get opened
  • not all the tests succeeded, but I do not know what I should do about that or how to resolve it

@droidmonkey droidmonkey added this to the v2.6.0 milestone Nov 23, 2019
@droidmonkey droidmonkey changed the title add DB_DIR placeholder for autoopen urls (Fixes #3863) Add DB_DIR placeholder for autoopen urls Nov 23, 2019
src/gui/DatabaseWidget.cpp Outdated Show resolved Hide resolved
src/core/Entry.cpp Outdated Show resolved Hide resolved
@stingray21
Copy link
Contributor Author

I still have the useless if (PlaceholderType::DbDir == PlaceholderType::DbDir) statement in the file Entry.ccp on line 899. What am I supposed to check here?

Also, where can I learn more about the tests? To figure out why test 1 and 15 failed.

@droidmonkey droidmonkey force-pushed the fix/add-autoopen-placeholder branch from 887a9fa to ded9c3f Compare May 21, 2020 03:01
@droidmonkey
Copy link
Member

Sorry for the extreme delay merging this, its good to go now.

@droidmonkey droidmonkey marked this pull request as ready for review May 21, 2020 03:02
@droidmonkey droidmonkey force-pushed the fix/add-autoopen-placeholder branch from ded9c3f to 0892764 Compare May 21, 2020 03:11
@droidmonkey droidmonkey merged commit d863496 into keepassxreboot:develop May 21, 2020
droidmonkey added a commit that referenced this pull request Jul 7, 2020
Added

- Custom Light and Dark themes [#4110, #4769, #4791, #4796, #4892, #4915]
- Compact mode to use classic Group and Entry line height [#4910]
- View menu to quickly switch themes, compact mode, and toggle UI elements [#4910]
- Search for groups and scope search to matched groups [#4705]
- Save Database Backup feature [#4550]
- Sort entries by "natural order" and move lines up/down [#4357]
- Option to launch KeePassXC on system startup/login [#4675]
- Caps Lock warning on password input fields [#3646]
- Add "Size" column to entry view [#4588]
- Browser-like tab experience using Ctrl+[Num] (Alt+[Num] on Linux) [#4063, #4305]
- Password Generator: Define additional characters to choose from [#3876]
- Reports: Database password health check (offline) [#3993]
- Reports: HIBP online service to check for breached passwords [#4438]
- Auto-Type: DateTime placeholders [#4409]
- Browser: Show group name in results sent to browser extension [#4111]
- Browser: Ability to define a custom browser location (macOS and Linux only) [#4148]
- Browser: Ability to change root group UUID and inline edit connection ID [#4315, #4591]
- CLI: `db-info` command [#4231]
- CLI: Use wl-clipboard if xclip is not available (Linux) [#4323]
- CLI: Incorporate xclip into snap builds [#4697]
- SSH Agent: Key file path env substitution, SSH_AUTH_SOCK override, and connection test [#3769, #3801, #4545]
- SSH Agent: Context menu actions to add/remove keys [#4290]

Changed

- Complete replacement of default database icons [#4699]
- Complete replacement of application icons [#4066, #4161, #4203, #4411]
- Complete rewrite of documentation and manpages using Asciidoctor [#4937]
- Complete refactor of config files; separate between local and roaming [#4665]
- Complete refactor of browser integration and proxy code [#4680]
- Complete refactor of hardware key integration (YubiKey and OnlyKey) [#4584, #4843]
- Significantly improve performance when saving and opening databases [#4309, #4833]
- Remove read-only detection for database files [#4508]
- Overhaul of password fields and password generator [#4367]
- Replace instances of "Master Key" with "Database Credentials" [#4929]
- Change settings checkboxes to positive phrasing for consistency [#4715]
- Improve UX of using entry actions (focus fix) [#3893]
- Set expiration time to Now when enabling entry expiration [#4406]
- Always show "New Entry" in context menu [#4617]
- Issue warning before adding large attachments [#4651]
- Improve importing OPVault [#4630]
- Improve AutoOpen capability [#3901, #4752]
- Check for updates every 7 days even while still running [#4752]
- Improve Windows installer UI/UX [#4675]
- Improve config file handling of portable distribution [#4131, #4752]
- macOS: Hide dock icon when application is hidden to tray [#4782]
- Browser: Use unlock dialog to improve UX of opening a locked database [#3698]
- Browser: Improve database and entry settings experience [#4392, #4591]
- Browser: Improve confirm access dialog [#2143, #4660]
- KeeShare: Improve monitoring file changes of shares [#4720]
- CLI: Rename `create` command to `db-create` [#4231]
- CLI: Cleanup `db-create` options (`--set-key-file` and `--set-password`) [#4313]
- CLI: Use stderr for help text and password prompts [#4086, #4623]
- FdoSecrets: Display existing secret service process [#4128]

Fixed

- Fix changing focus around the main window using tab key [#4641]
- Fix search field clearing while still using the application [#4368]
- Improve search help widget displaying on macOS and Linux [#4236]
- Return keyboard focus after editing an entry [#4287]
- Reset database path after failed "Save As" [#4526]
- Use SHA256 Digest for Windows code signing [#4129]
- Improve handling of ccache when building [#4104, #4335]
- macOS: Properly re-hide application window after browser integration and Auto-Type usage [#4909]
- Auto-Type: Fix crash when performing on new entry [#4132]
- Browser: Send legacy HTTP settings to recycle bin [#4589]
- Browser: Fix merging browser keys [#4685]
- CLI: Fix encoding when exporting database [#3921]
- SSH Agent: Improve reliability and underlying code [#3833, #4256, #4549, #4595]
- FdoSecrets: Fix crash when editing settings before service is enabled [#4332]
@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature Pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add path placeholders to autoopen functionality
3 participants