update yt-channel-info #2126
Merged
update yt-channel-info #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1303,7 +1303,7 @@ export default Vue.extend({ | |||
|
|
|||
| getChannelInfoLocal: function (channelId) { | |||
| return new Promise((resolve, reject) => { | |||
| ytch.getChannelInfo(channelId, 'latest').then(async (response) => { | |||
There was a problem hiding this comment.
not sure why 'latest' was provided here?
There was a problem hiding this comment.
Looks like a leftover from an early revision. Doesn't seem like it's needed.
ChunkyProgrammer
added
PR: waiting for review
auto-merge was automatically disabled
March 14, 2022 21:47
Pull request was converted to draft
|
relies on FreeTubeApp/yt-channel-info#61 getting merged |
Merged
1 task
|
LGTM |
efb4f5ff-1298-471a-8973-3d47447115dc
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update yt-channel-info
Important note
We may remove your pull request if you do not use this provided PR template correctly.
Pull Request Type
Please select what type of pull request this is:
Related issue
pr #1568
Description
Please write a clear and concise description of what the pull request does.
This includes fixes to the channel community parsing as well as adds the ability to parse Channel Stats, channel links & partial support for channel home pages,
Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Tested searching & navigating to all tabs on a channel's page. Haven't tested fetch subscription without RSS nor data import/export but they should be working.
Desktop (please complete the following information):
Additional context
Might want a yt-channel-info patch release before this gets merged