This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Fix for channels with no secondary links #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Empty secondaryLinks array is already created here yt-channel-info/app/youtube-grabber.js Line 28 in f4a85e0 This fix looks good to me. Thanks for taking the time to create a PR. |
ChunkyProgrammer
previously approved these changes
Feb 28, 2022
ChunkyProgrammer
requested review from
PrestonN,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
Closed
PikachuEXE
suggested changes
Mar 1, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
labels
|
They don't seem to be active on GitHub so i will commit the change |
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
2 tasks
|
@ChunkyProgrammer Ya but why remove the blank line, just removing the spaces is fine 😬 |
|
Idk i just did the "commit suggestion" feature on github |
PikachuEXE
approved these changes
Mar 15, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 15, 2022
ChunkyProgrammer
approved these changes
Mar 15, 2022
ChunkyProgrammer
added a commit
to Kylof61034/yt-channel-info
that referenced
this pull request
Mar 15, 2022
commit 243483f Author: SuperFurryCoder <100633427+SuperFurryCoder@users.noreply.github.com> Date: Tue Mar 15 20:07:14 2022 +0000 Fix for channels with no secondary links (FreeTubeApp#61) * Update youtube-grabber.js * Update youtube-grabber.js * Update youtube-grabber.js * Update youtube-grabber.js * remove unnecessary space Co-authored-by: PikachuEXE <pikachuexe@gmail.com> Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com> Co-authored-by: PikachuEXE <pikachuexe@gmail.com> commit 3291db3 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Feb 13 14:02:57 2022 -0500 Bump follow-redirects from 1.14.7 to 1.14.8 (FreeTubeApp#60) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
PrestonN
pushed a commit
that referenced
this pull request
Aug 24, 2022
* added typescript type definitions * Update typescript declarations * Add isOfficialArtist to channel object * Use multi-line comments Co-authored-by: Alexandra <bug.graph@gmail.com> * remove playlist url from getChannelVideos * Squashed commit of the following: commit 243483f Author: SuperFurryCoder <100633427+SuperFurryCoder@users.noreply.github.com> Date: Tue Mar 15 20:07:14 2022 +0000 Fix for channels with no secondary links (#61) * Update youtube-grabber.js * Update youtube-grabber.js * Update youtube-grabber.js * Update youtube-grabber.js * remove unnecessary space Co-authored-by: PikachuEXE <pikachuexe@gmail.com> Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com> Co-authored-by: PikachuEXE <pikachuexe@gmail.com> commit 3291db3 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Feb 13 14:02:57 2022 -0500 Bump follow-redirects from 1.14.7 to 1.14.8 (#60) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add getChannelStats and getChannelHome * fix HttpsProxyAgent reference * include types file in "files" Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com> Co-authored-by: Alexandra <bug.graph@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a channel with only primary links, causing the error:
debug TypeError: Cannot read property 'map' of undefined
debug at Function.getChannelInfo (///node_modules/yt-channel-info/app/youtube-grabber.js:40:68)
The structure of 'links' at that point was:
{
primaryLinks: [ { navigationEndpoint: [Object], icon: [Object], title: [Object] } ]
}
rather than:
{
primaryLinks: [ { navigationEndpoint: [Object], icon: [Object], title: [Object] } ],
secondaryLinks: [ { navigationEndpoint: [Object], icon: [Object], title: [Object] } ]
}
Not sure if you need to create empty secondaryLinks array instead at that point, but this fix works fine for me.