Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

added typescript type definitions #17

Merged
merged 14 commits into from
Aug 24, 2022
Merged

added typescript type definitions #17

merged 14 commits into from
Aug 24, 2022

Conversation

Kylof61034
Copy link
Contributor

@Kylof61034 Kylof61034 commented Feb 20, 2021 •
edited by efb4f5ff-1298-471a-8973-3d47447115dc
Loading

closes #38

PikachuEXE
PikachuEXE suggested changes Sep 21, 2021
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 3, 2021 •
edited
Loading

@PikachuEXE @ChunkyProgrammer @jasonhenriquez @peepopoggers @Hiers
Maybe also take this one over. Author hasn't been very active on GH.

edit: forgot to ping u guys.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc changed the base branch from master to development October 3, 2021 17:50
PikachuEXE
PikachuEXE previously approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot be sure all content in index.d.ts matches the doc (Too long to review all)
But since it can always be fixed later I will approve

PikachuEXE
PikachuEXE previously approved these changes Nov 16, 2021
View reviewed changes
@Slayug
Copy link
Contributor

Slayug commented Dec 15, 2021 •
edited
Loading

Are the last reviewers are aware of this ?
Do you think it possible to bypass all requirements ?

@PikachuEXE @ChunkyProgrammer @jasonhenriquez @peepopoggers @Hiers

@PikachuEXE
Copy link
Contributor

The dev team might be on vacation in Dec.
Thanks for checking the progress I think they will be back in Jan.
Is there any urgent need for this to be merged?

Slayug
Slayug reviewed Dec 15, 2021
View reviewed changes
Copy link
Contributor

@Slayug Slayug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better usage of comment fields

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@Slayug
Copy link
Contributor

Slayug commented Dec 15, 2021

@PikachuEXE thought dev team was inactive because there is no activity since october

@ChunkyProgrammer @Slayug
Use multi-line comments
0cb4534 
Co-authored-by: Alexandra <bug.graph@gmail.com>
auto-merge was automatically disabled February 8, 2022 02:09

Merge could not be authorized

@PrestonN PrestonN enabled auto-merge (squash) February 8, 2022 02:09
@ChunkyProgrammer
Merge branch 'development' into new-typings
6a50925
@ChunkyProgrammer
Squashed commit of the following:
17fe493 
commit 243483f
Author: SuperFurryCoder <100633427+SuperFurryCoder@users.noreply.github.com>
Date:   Tue Mar 15 20:07:14 2022 +0000

    Fix for channels with no secondary links (FreeTubeApp#61)

    * Update youtube-grabber.js

    * Update youtube-grabber.js

    * Update youtube-grabber.js

    * Update youtube-grabber.js

    * remove unnecessary space

    Co-authored-by: PikachuEXE <pikachuexe@gmail.com>

    Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>
    Co-authored-by: PikachuEXE <pikachuexe@gmail.com>

commit 3291db3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Sun Feb 13 14:02:57 2022 -0500

    Bump follow-redirects from 1.14.7 to 1.14.8 (FreeTubeApp#60)

    Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
    - [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
    - [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8)

    ---
    updated-dependencies:
    - dependency-name: follow-redirects
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ChunkyProgrammer
add getChannelStats and getChannelHome
bbf112c
PikachuEXE
PikachuEXE reviewed May 24, 2022
View reviewed changes
Copy link
Contributor

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would this PR also update app/youtube-grabber.js?

@ChunkyProgrammer
Copy link
Member

Why would this PR also update app/youtube-grabber.js?

I'm not sure, seems to be some merge issue

@PikachuEXE
Copy link
Contributor

CI failed due to service returning 503, not related

@PrestonN PrestonN merged commit fb63da4 into FreeTubeApp:development Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Slayug Slayug Slayug left review comments

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript Support
7 participants
@Kylof61034 @efb4f5ff-1298-471a-8973-3d47447115dc @Slayug @PikachuEXE @ChunkyProgrammer @absidue @PrestonN