Make the save as and open file dialogs blocking #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
absidue
changed the title
absidue
force-pushed
the
blocking-file-dialogs
branch
from
7459e94
to
1f5528c
Compare
PikachuEXE
approved these changes
Oct 13, 2022
ChunkyProgrammer
approved these changes
Oct 14, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 14, 2022
github-actions
bot
removed
the
PR: waiting for review
MarmadileManteater
added a commit
to MarmadileManteater/FreeTubeAndroid
that referenced
this pull request
Oct 18, 2022
commit 9733163 Merge: 25ff177 b5c486b Author: Emma <MarmadileManteater@proton.me> Merge branch 'FreeTubeApp:development' into development commit b5c486b Author: Emma <MarmadileManteater@proton.me> Fixing some leftover `showToast(obj)` (FreeTubeApp#2735) commit 198c3fa Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump http-proxy-agent from 4.0.1 to 5.0.0 (FreeTubeApp#2733) commit 25ff177 Merge: 980a387 4ef6369 Author: Emma <MarmadileManteater@proton.me> Merge branch 'upstream_development' into development commit 4ef6369 Author: Gediminas Murauskas <muziejusinfo@gmail.com> Translated using Weblate (Lithuanian) commit 4440044 Author: Massimo Pissarello <mapi68@gmail.com> Translated using Weblate (Italian) commit 8209e7e Author: Oğuz Ersen <oguz@ersen.moe> Translated using Weblate (Turkish) commit 3326224 Author: Jeff Huang <s8321414@gmail.com> Translated using Weblate (Chinese (Traditional)) commit 546a276 Author: Eric <hamburger1024@mailbox.org> Translated using Weblate (Chinese (Simplified)) commit 1b68e56 Author: Rex_sa <rex.sa@pm.me> Translated using Weblate (Arabic) commit 77a18e8 Merge: 62c70fb eefcd36 Author: Hosted Weblate <hosted@weblate.org> Merge branch 'origin/development' into Weblate. commit eefcd36 Author: Gediminas Murauskas <muziejusinfo@gmail.com> Translated using Weblate (Lithuanian) commit 94fb11f Author: Grzegorz Wójcicki <terkaz@gmx.com> Translated using Weblate (Polish) commit 37b3b6d Author: J. Lavoie <j.lavoie@net-c.ca> Translated using Weblate (French) commit 097c06a Author: J. Lavoie <j.lavoie@net-c.ca> Translated using Weblate (German) commit 62c70fb Author: absidue <48293849+absidue@users.noreply.github.com> Fix fetching the comments from invidious (FreeTubeApp#2721) commit 077fde7 Author: absidue <48293849+absidue@users.noreply.github.com> Fix CTRL+clicking on the channel name on the watch page (FreeTubeApp#2713) commit ad01d2b Author: absidue <48293849+absidue@users.noreply.github.com> Make the safe as and open file dialogs blocking (FreeTubeApp#2712) commit 3aa080d Author: absidue <48293849+absidue@users.noreply.github.com> Make showToast a helper (FreeTubeApp#2695) commit f94d8a9 Author: Emma <MarmadileManteater@proton.me> Filtering out invidious instances that don't support the API (FreeTubeApp#2714) commit 21a31cf Author: PikachuEXE <pikachuexe@gmail.com> Upgrade electron from 20 > 21 (FreeTubeApp#2717) commit c0f98ee Author: absidue <48293849+absidue@users.noreply.github.com> Use named parameters instead of $ and % in localised strings (FreeTubeApp#2685) commit 81426ed Author: absidue <48293849+absidue@users.noreply.github.com> Don't lint while rebasing (FreeTubeApp#2711) commit 1695605 Author: Aiz <66974576+Aiz0@users.noreply.github.com> Remove deprecated @keypress + some accessability improvements (FreeTubeApp#2697) commit b35d7ea Author: Sveinn í Felli <sv1@fellsnet.is> Translated using Weblate (Icelandic) commit 6b4727c Merge: bc8261d9 2a60129 Author: Hosted Weblate <hosted@weblate.org> Merge branch 'origin/development' into Weblate. commit 2a60129 Author: Fjuro <ifjuro@proton.me> Translated using Weblate (Czech) commit 5199114 Author: ovari <ovari123@zoho.com> Translated using Weblate (Hungarian) commit 11b3c19 Author: Yaron Shahrabani <sh.yaron@gmail.com> Translated using Weblate (Hebrew) commit bd210ab Author: Егор Ермаков <eg.ermakov2016@yandex.ru> Translated using Weblate (Russian) commit bc8261d Author: absidue <48293849+absidue@users.noreply.github.com> Move colours from the store to the utils helper (FreeTubeApp#2710) commit f12b9e1 Author: SC <lalocas@protonmail.com> Translated using Weblate (Portuguese) **Full Changelog**: 0.17.1-nightly-68...0.17.1-nightly-69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the save as and open file dialogs blocking
Pull Request Type
Description
Currently the Save as... and Open file... dialogs are non-blocking, which means you can switch back to the FreeTube window and open as many of those dialogs as you want or navigate to a different page, causing unexpected behaviour when you select a file.
As we aren't Discord, I decided to fix that bug, so that when one of those dialogs is open, you have to deal with it before you can return to FreeTube.
Testing
The easiest place to test this is in the data import and export settings, by opening on of those dialogs and then attempting to click into the FreeTube window. On Windows the dialog window will flash for a short moment. It should stop you from going back to the FreeTube window until you cancel or select a file to open/save to.
Desktop