Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playlists not showing up on artist topic channels with the local API #4129

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix playlists not showing up on artist topic channels with the local API #4129

merged 1 commit into from
Oct 16, 2023

Conversation

absidue
Copy link
Member

@absidue absidue commented Oct 10, 2023

Fix playlists not showing up on artist topic channels with the local API

Pull Request Type

  • Bugfix

Description

Currently when you visit an artist topic channel e.g. Rihanna - Topic on the local API, the playlists tab will be empty. This is caused by those channels having the Created Playlists category despite not actually having any playlists that they own, instead we need to use the Albums & Singles category, which isn't empty and contains Album playlists, which aren't tied directly to any channel (playlist ID starts with OL).

Screenshots

before:
before

after:
after

Testing

https://www.youtube.com/channel/UCvWtix2TtWGe9kffqnwdaMw

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.19.1

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 10, 2023 17:39
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 10, 2023
@ChunkyProgrammer
Copy link
Member

Some channels do have a created playlist section.
Ex: https://www.youtube.com/channel/UCpS0hJ21amjA5eBApEOiIFw/playlists

Also, just wanted to add, for my Invidious PR, I added the option to select different categories which could be a nice addition to this PR (we can default to created songs and albums).

iv-org/invidious#4026

@absidue
Copy link
Member Author

absidue commented Oct 10, 2023

Do we use YouTube's labels for the categories (they'll always be English US) or do we hardcode specific ones and only display those?

@ChunkyProgrammer
Copy link
Member

Do we use YouTube's labels for the categories (they'll always be English US) or do we hardcode specific ones and only display those?

I think a mix could be good (use hard coded specific ones when possible so we can have them translated, use youtube ones if they cant be mapped)

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Lets just go for the route of adding the things @ChunkyProgrammer suggested. After implementing it update testing description if needed

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Oct 16, 2023
@absidue
Copy link
Member Author

absidue commented Oct 16, 2023

🙈
Guess I'll have to go down that rabbit hole of YouTube edge cases then and figure out when I have to hide the sorting options and get the UI working properly with two drop downs. So that it doesn't turn into too much of a shit show, I'll just hard code allowed options, that way if it encounters unknown ones it can ignore them, feels safer than trusting YouTube, especially after the recent published date fiasco.

(was really hoping you peeps would decided that this bug fix can go ahead as is, instead of turning it into a feature implementation that will introduce new bugs 🙈, cause that's what always happens when I implement a feature.)

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought lets leave that for a future PR. Sounds way to complicated to add that here

@FreeTubeBot FreeTubeBot merged commit 05499ce into FreeTubeApp:development Oct 16, 2023
5 checks passed
@absidue absidue deleted the local-artist-topic-playlists branch October 16, 2023 20:23
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Oct 17, 2023
@PikachuEXE
Merge branch 'development' into feature/playlist-2023-05
7dd6d97 
* development:
  Bump webpack from 5.88.2 to 5.89.0 (FreeTubeApp#4168)
  Fix playlists not showing up on artist topic channels with the local API (FreeTubeApp#4129)
  Bump undici from 5.19.1 to 5.26.3 (FreeTubeApp#4173)
  Bump marked from 9.1.0 to 9.1.2 (FreeTubeApp#4171)
  Bump sass from 1.69.0 to 1.69.3 (FreeTubeApp#4169)
  Bump the eslint group with 2 updates (FreeTubeApp#4166)
  Bump the babel group with 2 updates (FreeTubeApp#4165)
  Truncate title of playlist in queue window (FreeTubeApp#4134)
  Wrap channel tabs as soon as there isn't enough screen space (FreeTubeApp#4139)
  Keep download folder path when changing to 'ask for download path' and back (FreeTubeApp#4101)
  Add external player support for Baka, Celluloid & Haruna (FreeTubeApp#4067)
  Fix error when clicking on the current quality in the DASH quality selector (FreeTubeApp#4130)
@absidue absidue mentioned this pull request Jun 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@absidue @ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE @FreeTubeBot