-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel: display playlists for autogenerated channels + include channel tags in api #4026
Closed
ChunkyProgrammer
wants to merge
4
commits into
iv-org:master
from
ChunkyProgrammer:add-support-for-channel-playlist
Closed
Channel: display playlists for autogenerated channels + include channel tags in api #4026
ChunkyProgrammer
wants to merge
4
commits into
iv-org:master
from
ChunkyProgrammer:add-support-for-channel-playlist
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunkyProgrammer
force-pushed
the
add-support-for-channel-playlist
branch
from
August 1, 2023 19:57
bbdc2d6
to
f1a5535
Compare
SamantazFox
reviewed
Aug 3, 2023
SamantazFox
reviewed
Aug 3, 2023
SamantazFox
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
syeopite
added
the
need-testing
This feature needs to be deployed and tested to see if it's working, and doesn't break something
label
Aug 6, 2023
SamantazFox
approved these changes
Aug 7, 2023
SamantazFox
added
in-testing
This feature has been deployed and is being tested
and removed
need-testing
This feature needs to be deployed and tested to see if it's working, and doesn't break something
labels
Aug 8, 2023
ChunkyProgrammer
force-pushed
the
add-support-for-channel-playlist
branch
from
August 30, 2023 04:14
3998987
to
9c0a61b
Compare
@SamantazFox issues should be fixed now. |
ChunkyProgrammer
force-pushed
the
add-support-for-channel-playlist
branch
from
August 30, 2023 04:17
9c0a61b
to
c6a71fa
Compare
ChunkyProgrammer
force-pushed
the
add-support-for-channel-playlist
branch
from
September 19, 2023 00:11
c6a71fa
to
cc93abd
Compare
Merged
1 task
ChunkyProgrammer
force-pushed
the
add-support-for-channel-playlist
branch
from
October 16, 2023 04:31
cc93abd
to
cff5fc1
Compare
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
ChunkyProgrammer
force-pushed
the
add-support-for-channel-playlist
branch
from
November 11, 2023 01:36
cff5fc1
to
d61acbe
Compare
Seems like this no longer works? (Judging from the matrix chat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hoping to add channel tags to the api and noticed some issues with autogenerated channels
/channel/UCpS0hJ21amjA5eBApEOiIFw/playlists?sort_by=albums_and_singles
/channel/UCpS0hJ21amjA5eBApEOiIFw/playlists?sort_by=created_playlists
/channel/UCXwcsxJcdxfvsFiVtrOgy4Q/playlists?sort_by=albums_and_singles
/channel/UCXwcsxJcdxfvsFiVtrOgy4Q/playlists?sort_by=created_playlists
Tags:
auto generated channel (Minecraft - Topic):
/api/v1/channels/UCQvWX73GQygcwXOTSf_VDVg?pretty=1&fields=tags
other channel (Mr Beast):
/api/v1/channels/UCX6OQ3DkcsbYNE6H8uQQuVA?pretty=1&fields=tags