Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel: display playlists for autogenerated channels + include channel tags in api #4026

Conversation

ChunkyProgrammer
Copy link
Contributor

@ChunkyProgrammer ChunkyProgrammer commented Aug 1, 2023

I was hoping to add channel tags to the api and noticed some issues with autogenerated channels

/channel/UCpS0hJ21amjA5eBApEOiIFw/playlists?sort_by=albums_and_singles
image

/channel/UCpS0hJ21amjA5eBApEOiIFw/playlists?sort_by=created_playlists
image

/channel/UCXwcsxJcdxfvsFiVtrOgy4Q/playlists?sort_by=albums_and_singles
image

/channel/UCXwcsxJcdxfvsFiVtrOgy4Q/playlists?sort_by=created_playlists
image

Tags:
auto generated channel (Minecraft - Topic):
/api/v1/channels/UCQvWX73GQygcwXOTSf_VDVg?pretty=1&fields=tags

other channel (Mr Beast):
/api/v1/channels/UCX6OQ3DkcsbYNE6H8uQQuVA?pretty=1&fields=tags

Copy link
Member

@SamantazFox SamantazFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@syeopite syeopite added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Aug 6, 2023
@SamantazFox SamantazFox added in-testing This feature has been deployed and is being tested and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Aug 8, 2023
@SamantazFox
Copy link
Member

Deployed on the test instance!

Funny how that channel is restricted there:
image

@SamantazFox
Copy link
Member

So, I've tried using the channel you gave as an example.


The home page still redirects to the list of videos by default, but the GUI doesn't show it (there is no "videos" text above "playlists):

image


Then, on the playlists page, the sort options are wrong

image

@ChunkyProgrammer
Copy link
Contributor Author

@SamantazFox issues should be fixed now.

@ChunkyProgrammer
Copy link
Contributor Author

ChunkyProgrammer commented Nov 22, 2023

Seems like this no longer works? (Judging from the matrix chat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-testing This feature has been deployed and is being tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants