Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set icon dropdown position to left on watch-video-info on narrow displays #4660

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Set icon dropdown position to left on watch-video-info on narrow displays #4660

merged 1 commit into from
Feb 9, 2024

Conversation

MarmadileManteater
Copy link
Contributor

Set icon dropdown position to left in watch-video-info on narrow displays

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Description

The ft-icon-buttons in watch-video-info recently moved from the left to the right side of the screen on mobile. However, the dropdowns for these buttons are still positioned to the right causing them to overflow the screen. This PR addresses this by positioning them to the left.

Screenshots

before after
image image

Testing

  1. Open any video
  2. Ensure display width is <=680px
  3. Ensure the icon drop-downs in the watch video info don't cause the screen to overflow

Desktop

  • OS: Windows 10
  • OS Version: Pro Version 21H2 Installed on ‎4/‎3/‎2022 OS build 19044.1889 Experience Windows Feature Experience Pack 120.2212.4180.0
  • FreeTube version: bf83faa

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 9, 2024 13:16
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 9, 2024
kommunarr
kommunarr approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@kommunarr kommunarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FreeTubeBot FreeTubeBot merged commit deb2f99 into FreeTubeApp:development Feb 9, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 9, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Very unrelated to this PR but noticed it while fiddling around when testing this. Would you maybe want to address this :)

FreeTube_3wFGWHs878.mp4

@MarmadileManteater MarmadileManteater mentioned this pull request Feb 14, 2024
Merged
4 tasks
@MarmadileManteater MarmadileManteater deleted the hang-left branch March 16, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kommunarr kommunarr kommunarr approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE Awaiting requested review from PikachuEXE

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc Awaiting requested review from efb4f5ff-1298-471a-8973-3d47447115dc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MarmadileManteater @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @ChunkyProgrammer @kommunarr @FreeTubeBot