Fix overflow issue with share playlist icon drop-down #4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, when this overflow-y was added, the share playlist dropdown went straight down, so there would no need for the content to be able to overflow in the y direction. (FreeTubeApp#2281) Now, the dropdown swings out to the left by default, and even when it is centered, it still overflows the width of the container as an intentional part of the design.
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 14, 2024
PikachuEXE
approved these changes
Feb 15, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer and
absidue
absidue
approved these changes
Feb 15, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Feb 15, 2024
…-user-playlist-2 * development: (66 commits) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Estonian) Translated using Weblate (Turkish) Translated using Weblate (Spanish) Translated using Weblate (Arabic) Translated using Weblate (Italian) Translated using Weblate (Polish) Translated using Weblate (French) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Fix overflow issue with share playlist icon drop-down (FreeTubeApp#4677) Fix the Invidious DASH manifest generation (FreeTubeApp#4672) Hide channel sidebar label under `more` when setting is enabled (FreeTubeApp#4678) Translated using Weblate (Norwegian Nynorsk) Translated using Weblate (Serbian) Remove excessive punctuation as part of distraction settings (FreeTubeApp#4673) Bump the stylelint group with 1 update (FreeTubeApp#4669) Bump swiper from 11.0.5 to 11.0.6 (FreeTubeApp#4670) ... # Conflicts: # src/renderer/components/playlist-info/playlist-info.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix overflow issue with share playlist icon drop-down
Pull Request Type
Related issue
#4660 (comment)
Description
The share playlist drop-down currently overflows in a way which visually obscures its content. This PR addresses this by removing the
overflow-y: auto;onplaylistInfoas well as adding a media query which positions the drop down to the center when the width is<=1250px.Screenshots
Testing
share playlisticon1200pxand900pxDesktop