Remove excessive punctuation as part of distraction settings #4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
MitchelPaulin
changed the title
PikachuEXE
reviewed
Feb 12, 2024
src/renderer/helpers/utils.js
Outdated
| return title.replace(reg, x => capitalizedWord(x.toLowerCase())) | ||
| return title | ||
| .replaceAll(/!{2,}/g, '!') | ||
| .replaceAll(/[!?|]{2,}/g, '?') |
There was a problem hiding this comment.
Why [!?|]{2,} not \?{2,}
There was a problem hiding this comment.
To deal with strings like TITLE???!??!!!!!?
If you only matched ? and ! separately you would end up with TITLE?!?!? rather than TITLE?
There was a problem hiding this comment.
/[!?]{2,}/gis enough (without|)- Please provide test case (video) for title with
?!?!?
There was a problem hiding this comment.
Co-authored-by: PikachuEXE <git@pikachuexe.net>
auto-merge was automatically disabled
February 12, 2024 23:36
Head branch was pushed to by a user without write access
…lin/FreeTube into Excessive-Punctuation
auto-merge was automatically disabled
February 13, 2024 02:36
Head branch was pushed to by a user without write access
PikachuEXE
approved these changes
Feb 13, 2024
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
kommunarr
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 13, 2024
absidue
approved these changes
Feb 13, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Feb 15, 2024
…-user-playlist-2 * development: (66 commits) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Estonian) Translated using Weblate (Turkish) Translated using Weblate (Spanish) Translated using Weblate (Arabic) Translated using Weblate (Italian) Translated using Weblate (Polish) Translated using Weblate (French) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Fix overflow issue with share playlist icon drop-down (FreeTubeApp#4677) Fix the Invidious DASH manifest generation (FreeTubeApp#4672) Hide channel sidebar label under `more` when setting is enabled (FreeTubeApp#4678) Translated using Weblate (Norwegian Nynorsk) Translated using Weblate (Serbian) Remove excessive punctuation as part of distraction settings (FreeTubeApp#4673) Bump the stylelint group with 1 update (FreeTubeApp#4669) Bump swiper from 11.0.5 to 11.0.6 (FreeTubeApp#4670) ... # Conflicts: # src/renderer/components/playlist-info/playlist-info.scss
|
Would like to have a way to see the original title before any DeArrowing of the title if possible, essentially: #3900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Pull Request Type
Related issue
close #4268
Description
Filters out excessive use of punctuation consisting of ! and ? if you have the capitalization setting already enabled
Screenshots
Setting ON:
Setting OFF:
Testing
gothanchessgothanchess what am Ifor example of?!?!Desktop
Additional context