Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflow issue with share playlist icon drop-down #4677

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Fix overflow issue with share playlist icon drop-down #4677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6281d48
Set share playlist dropdown position to `center` w/ media query
MarmadileManteater Feb 14, 2024
83a47cf
Remove overflow-y as it causes the overflow issue
MarmadileManteater Feb 14, 2024
9bf451c
Remove unnecessary whitespace
MarmadileManteater Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/renderer/components/playlist-info/playlist-info.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,10 @@
column-gap: 8px;
justify-content: flex-end;
}

@media only screen and (max-width: 1250px) {
:deep(.sharePlaylistIcon .iconDropdown) {
inset-inline-start: auto;
inset-inline-end: auto;
}
}
1 change: 1 addition & 0 deletions src/renderer/components/playlist-info/playlist-info.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@
<ft-share-button
v-if="sharePlaylistButtonVisible"
:id="id"
class="sharePlaylistIcon"
:dropdown-position-y="description ? 'top' : 'bottom'"
share-target-type="Playlist"
/>
Expand Down
1 change: 0 additions & 1 deletion src/renderer/views/Playlist/Playlist.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
box-sizing: border-box;
block-size: calc(100vh - 132px);
margin-inline-end: 1em;
overflow-y: auto;
padding: 10px;
position: sticky;
inset-block-start: 96px;
Expand Down
Loading