SVG assets #4898
Merged
SVG assets #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
|
How do you create the SVG files? For reviewers: You have to click on |
|
I recreated them from larger PNGs with Affinity Designer |
|
would this solve #2007 ? |
|
No, I didn't touch this particular icon |
|
Could you also address that one? |
auto-merge was automatically disabled
April 11, 2024 08:58
Head branch was pushed to by a user without write access
It didn't seem jagged on my display, but nevertheless, I recreated the Windows icon in a higher res version -- from 1024x1024 all the way down to 16x16. Can you download the icon itself and check if it displays better for you? |
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Apr 11, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE,
absidue,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
1 task
absidue
reviewed
Apr 11, 2024
DeaDvey
added a commit
to DeaDvey/FreeTube-Gruvboxtheme
that referenced
this pull request
Apr 11, 2024
auto-merge was automatically disabled
April 12, 2024 06:44
Head branch was pushed to by a user without write access
HighlanderCZ
dismissed stale reviews from kommunarr and efb4f5ff-1298-471a-8973-3d47447115dc
via
33d1160
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 12, 2024
PikachuEXE
approved these changes
Apr 12, 2024
absidue
approved these changes
Apr 12, 2024
github-actions
bot
removed
the
PR: waiting for review
Merged
1 task
4 tasks
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVG assets instead of blurry PNGs
Pull Request Type
Related issue
#2007
Description
Changes icon and logo in the top bar for all themes to use SVG assets instead of PNGs.
Screenshots
Testing
The app runs correctly in dev environment and builds without errors.
Desktop