-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize images #5147
Optimize images #5147
Conversation
d5a8d69
I tried https://github.com/svg/svgo locally after checking out this branch and see better reported results No idea what to use for PNG & ICO yet (I might or might not find a tool for those) Edit 1: Found an action which uses svgo and got other image optimizations: https://github.com/marketplace/actions/imgcmp |
Oh looks promissing. The SVG tool I used does lossless compression but this one doesnt specify so got to look into that. The other tools i used use lossy compression. But we indeed can leave this for another PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK let's see if possible to use the new action in another PR (how to test though ?_?
SVGO got a default preset of plugins, not sure lossless or not
https://svgo.dev/docs/preset-default/
Optimize images
Pull Request Type
Related issue
#4976 #4898
Description
The new high quality SVG's are awesome but increased our image size allot compared to the old ones. I went on a quest to optimize our images for the gazillionth time and it looked like I was successful :)
Screenshots
Before:
After:
Testing
Check if all the images appear the same, check for quality reduction
Additional context
Tools used:
A little bird (@absidue) told me about this issue and that what triggered this side quest :)