-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local API: Add support for home tab on channels #6033
base: development
Are you sure you want to change the base?
Local API: Add support for home tab on channels #6033
Conversation
src/renderer/components/distraction-settings/distraction-settings.vue
Outdated
Show resolved
Hide resolved
c127bab
to
07a1f0b
Compare
How should we handle related/featured channels and game cards? Before this pull request they were shown on the about tab but now they are duplicated to the home page too. If we move them to the home page we need to make sure that the "Hide Feature Channels" setting still works. |
e20d70b
to
6b3aab2
Compare
Good point, I think it's okay for the information to be duplicated on the home page as long as the code isn't duplicated (ex: we should set the featuredchannels as part of the home page parsing instead of having a separate method for parsing it). I'll look into getting the hide featured channels to work with the homepage as well |
Done: 43aeeef |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Is it possible to hide shorts when the distraction free setting is enabled? |
I think it'd be possible to hide some of the shorts on the home page but not all of them (I'll have to double check). Also, would we want to hide shorts on the home page? I thought the hide shorts setting was just for hiding the shorts tab? |
3a0a006
to
f0884b8
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
I interpretation is that |
Yeah maybe its best to just leave this as is |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
4bcbddf
to
17334f4
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com>
…in this function
5dbae67
to
a3548aa
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com>
a3548aa
to
691fde1
Compare
Local API: Add support for home tab on channels
Pull Request Type
Description
This PR adds support for parsing the home page on channels
Screenshots
Testing
(Make sure to use Local API as primary API!)
go to a variety of different channels (ex: Linus Tech Tips, Music, - Topic channels)
make sure home page properly displays
try disabling channel homepage in distraction free settings
make sure that homepage is no longer visible
Desktop