Local API: Add support for home tab on channels #6033

ChunkyProgrammer · 2024-10-30T05:08:01Z

Local API: Add support for home tab on channels

Pull Request Type

Feature Implementation

Description

This PR adds support for parsing the home page on channels

Screenshots

Testing

(Make sure to use Local API as primary API!)

go to a variety of different channels (ex: Linus Tech Tips, Music, - Topic channels)
make sure home page properly displays
try disabling channel homepage in distraction free settings
make sure that homepage is no longer visible

Desktop

OS: Linux Mint
OS Version: 22
FreeTube version: 0.22.0

src/renderer/components/channel-home/channel-home.js

src/renderer/components/distraction-settings/distraction-settings.vue

src/renderer/components/ChannelDetails/ChannelDetails.vue

absidue · 2024-10-30T14:21:24Z

How should we handle related/featured channels and game cards? Before this pull request they were shown on the about tab but now they are duplicated to the home page too. If we move them to the home page we need to make sure that the "Hide Feature Channels" setting still works.

ChunkyProgrammer · 2024-10-30T16:05:16Z

How should we handle related/featured channels and game cards? Before this pull request they were shown on the about tab but now they are duplicated to the home page too. If we move them to the home page we need to make sure that the "Hide Feature Channels" setting still works.

Good point, I think it's okay for the information to be duplicated on the home page as long as the code isn't duplicated (ex: we should set the featuredchannels as part of the home page parsing instead of having a separate method for parsing it).

I'll look into getting the hide featured channels to work with the homepage as well

ChunkyProgrammer · 2024-10-30T16:41:50Z

Good point, I think it's okay for the information to be duplicated on the home page as long as the code isn't duplicated (ex: we should set the featuredchannels as part of the home page parsing instead of having a separate method for parsing it).

I'll look into getting the hide featured channels to work with the homepage as well

Done: 43aeeef

github-actions · 2024-11-02T10:40:23Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

efb4f5ff-1298-471a-8973-3d47447115dc · 2024-11-02T14:34:56Z

Is it possible to hide shorts when the distraction free setting is enabled?

ChunkyProgrammer · 2024-11-02T17:29:53Z

Is it possible to hide shorts when the distraction free setting is enabled?

I think it'd be possible to hide some of the shorts on the home page but not all of them (I'll have to double check).

Also, would we want to hide shorts on the home page? I thought the hide shorts setting was just for hiding the shorts tab?

github-actions · 2024-11-04T02:54:36Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

PikachuEXE · 2024-11-04T03:10:54Z

Also, would we want to hide shorts on the home page? I thought the hide shorts setting was just for hiding the shorts tab?

I interpretation is that Hide Channel Shorts is for hiding any displayed shorts in single channel view & channel short tab is the only place before home tab is introduced

efb4f5ff-1298-471a-8973-3d47447115dc · 2024-11-06T22:50:35Z

Also, would we want to hide shorts on the home page? I thought the hide shorts setting was just for hiding the shorts tab?

I interpretation is that Hide Channel Shorts is for hiding any displayed shorts in single channel view & channel short tab is the only place before home tab is introduced

Yeah maybe its best to just leave this as is

github-actions · 2024-11-08T04:51:01Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

absidue · 2024-11-25T16:58:28Z

When visiting an artist topic channel such as https://www.youtube.com/channel/UCRw0x9_EfawqmgDI2IgQLLg I noticed that the home page is empty and the console contains warnings about an unknown lockup view type ALBUM. The data structure for that type seems to be the same as for playlists and podcasts, as it should just be a one line change to add that type to the switch-case, could you please do it as part of this pull requests? Everything else LGTM! :)

ChunkyProgrammer · 2024-11-25T17:03:29Z

as it should just be a one line change to add that type to the switch-case, could you please do it as part of this pull requests? Everything else LGTM! :)

Updated

PikachuEXE · 2024-11-25T22:45:34Z

For special channel like https://www.youtube.com/channel/UCStaiwu-FAgp_RC_tBiLh9A I see video tab selected (even though home tab can be used)
Any reason?

…age isnt hidden when entering a channel url

ChunkyProgrammer · 2024-11-25T23:39:13Z

For special channel like https://www.youtube.com/channel/UCStaiwu-FAgp_RC_tBiLh9A I see video tab selected (even though home tab can be used) Any reason?

Should be fixed now

efb4f5ff-1298-471a-8973-3d47447115dc · 2024-12-02T22:29:48Z

Is this considered a bug? When navigating back to the channel Videos is highlighted but i expected Home to be highlighted after i disabled the distraction free toggle

VirtualBoxVM_CzWW95LiNM.mp4

ChunkyProgrammer · 2024-12-02T22:42:03Z

@efb4f5ff-1298-471a-8973-3d47447115dc if you're going back to the channel then that wouldnt be a bug

* Add support for home tab on channels * Remove some unneeded code * Add setting to hide channel home tab * Switch to Composition API * Add Play All link when possible, parse more types * fix typo for home tab aria-controls Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com> * move distraction free hide home setting * Filter home data for setting featured channels * fix publish date parsing * Add support for shelf subtitle * run lint-fix * add jsdoc for added function * implement code suggestions, fix lockupview * add support for parsing subtitle and playlistId for richshelf * exclude home tab for IV * implement code suggestions, change `Play all` to `View playlist` Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com> * remove lockupview case since FreeTubeApp#6196 will handle parsing it in this function * use list icon instead of bookmark icon Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com> * open all details by default * add case 'ALBUM' for lockupView parsing * change default page to home page when local api is enabled and home page isnt hidden when entering a channel url --------- Co-authored-by: absidue <48293849+absidue@users.noreply.github.com> Co-authored-by: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com>

efb4f5ff-1298-471a-8973-3d47447115dc · 2025-02-05T19:52:38Z

We forgot to hide the home tab when there is no content listed on it.

Go to any video
Load comments
Click on one of the profiles
See empty home tab

github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 30, 2024

FreeTubeBot enabled auto-merge (squash) October 30, 2024 05:08

ChunkyProgrammer changed the title ~~Add support for home tab~~ Local API: Add support for home tab on channels Oct 30, 2024

absidue reviewed Oct 30, 2024

View reviewed changes

src/renderer/components/channel-home/channel-home.js Outdated Show resolved Hide resolved

src/renderer/components/distraction-settings/distraction-settings.vue Outdated Show resolved Hide resolved

src/renderer/components/ChannelDetails/ChannelDetails.vue Outdated Show resolved Hide resolved

ChunkyProgrammer force-pushed the add-support-for-home-tab branch from c127bab to 07a1f0b Compare October 30, 2024 14:15

ChunkyProgrammer requested review from PikachuEXE, absidue and kommunarr October 30, 2024 14:16

ChunkyProgrammer force-pushed the add-support-for-home-tab branch from e20d70b to 6b3aab2 Compare October 30, 2024 15:59

absidue requested a review from efb4f5ff-1298-471a-8973-3d47447115dc October 30, 2024 22:35

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Nov 2, 2024

ChunkyProgrammer force-pushed the add-support-for-home-tab branch from 3a0a006 to f0884b8 Compare November 4, 2024 02:54

github-actions bot removed the PR: merge conflicts / rebase needed label Nov 4, 2024

ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 6, 2024

efb4f5ff-1298-471a-8973-3d47447115dc previously approved these changes Nov 6, 2024

View reviewed changes

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Nov 8, 2024

ChunkyProgrammer dismissed efb4f5ff-1298-471a-8973-3d47447115dc’s stale review via 17334f4 November 10, 2024 02:28

ChunkyProgrammer force-pushed the add-support-for-home-tab branch from 4bcbddf to 17334f4 Compare November 10, 2024 02:28

PikachuEXE previously approved these changes Nov 25, 2024

View reviewed changes

add case 'ALBUM' for lockupView parsing

8a984d7

ChunkyProgrammer dismissed stale reviews from PikachuEXE and efb4f5ff-1298-471a-8973-3d47447115dc via 8a984d7 November 25, 2024 17:02

ChunkyProgrammer requested review from PikachuEXE and efb4f5ff-1298-471a-8973-3d47447115dc November 25, 2024 17:02

absidue previously approved these changes Nov 25, 2024

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc previously approved these changes Nov 25, 2024

View reviewed changes

change default page to home page when local api is enabled and home p…

e516619

…age isnt hidden when entering a channel url

ChunkyProgrammer dismissed stale reviews from efb4f5ff-1298-471a-8973-3d47447115dc and absidue via e516619 November 25, 2024 23:38

ChunkyProgrammer requested review from absidue and efb4f5ff-1298-471a-8973-3d47447115dc November 25, 2024 23:39

PikachuEXE approved these changes Nov 26, 2024

View reviewed changes

absidue approved these changes Nov 26, 2024

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Dec 2, 2024

View reviewed changes

FreeTubeBot merged commit 719fcc0 into FreeTubeApp:development Dec 2, 2024
5 checks passed

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 2, 2024

ChunkyProgrammer deleted the add-support-for-home-tab branch December 2, 2024 23:21

OothecaPickle mentioned this pull request Dec 6, 2024

Show precise view counts for videos on search results page (Local API) #6284

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Local API: Add support for home tab on channels #6033

Local API: Add support for home tab on channels #6033

ChunkyProgrammer commented Oct 30, 2024 •

edited

Loading

absidue commented Oct 30, 2024 •

edited

Loading

ChunkyProgrammer commented Oct 30, 2024

ChunkyProgrammer commented Oct 30, 2024

github-actions bot commented Nov 2, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 2, 2024

ChunkyProgrammer commented Nov 2, 2024

github-actions bot commented Nov 4, 2024

PikachuEXE commented Nov 4, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 6, 2024

github-actions bot commented Nov 8, 2024

absidue commented Nov 25, 2024 •

edited

Loading

ChunkyProgrammer commented Nov 25, 2024

PikachuEXE commented Nov 25, 2024

ChunkyProgrammer commented Nov 25, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Dec 2, 2024

ChunkyProgrammer commented Dec 2, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 5, 2025 •

edited

Loading

Local API: Add support for home tab on channels #6033

Local API: Add support for home tab on channels #6033

Conversation

ChunkyProgrammer commented Oct 30, 2024 • edited Loading

Local API: Add support for home tab on channels

Pull Request Type

Description

Screenshots

Testing

Desktop

absidue commented Oct 30, 2024 • edited Loading

ChunkyProgrammer commented Oct 30, 2024

ChunkyProgrammer commented Oct 30, 2024

github-actions bot commented Nov 2, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 2, 2024

ChunkyProgrammer commented Nov 2, 2024

github-actions bot commented Nov 4, 2024

PikachuEXE commented Nov 4, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 6, 2024

github-actions bot commented Nov 8, 2024

absidue commented Nov 25, 2024 • edited Loading

ChunkyProgrammer commented Nov 25, 2024

PikachuEXE commented Nov 25, 2024

ChunkyProgrammer commented Nov 25, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Dec 2, 2024

ChunkyProgrammer commented Dec 2, 2024

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 5, 2025 • edited Loading

ChunkyProgrammer commented Oct 30, 2024 •

edited

Loading

absidue commented Oct 30, 2024 •

edited

Loading

absidue commented Nov 25, 2024 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 5, 2025 •

edited

Loading