Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local API: Add support for home tab on channels #6033

Open
wants to merge 18 commits into
base: development
Choose a base branch
from

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Oct 30, 2024

Local API: Add support for home tab on channels

Pull Request Type

  • Feature Implementation

Description

This PR adds support for parsing the home page on channels

Screenshots

image
image
image
image

Testing

(Make sure to use Local API as primary API!)

  • go to a variety of different channels (ex: Linus Tech Tips, Music, - Topic channels)

  • make sure home page properly displays

  • try disabling channel homepage in distraction free settings

  • make sure that homepage is no longer visible

Desktop

  • OS: Linux Mint
  • OS Version: 22
  • FreeTube version: 0.22.0

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 30, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 30, 2024 05:08
@ChunkyProgrammer ChunkyProgrammer changed the title Add support for home tab Local API: Add support for home tab on channels Oct 30, 2024
@absidue
Copy link
Member

absidue commented Oct 30, 2024

How should we handle related/featured channels and game cards? Before this pull request they were shown on the about tab but now they are duplicated to the home page too. If we move them to the home page we need to make sure that the "Hide Feature Channels" setting still works.

@ChunkyProgrammer
Copy link
Member Author

How should we handle related/featured channels and game cards? Before this pull request they were shown on the about tab but now they are duplicated to the home page too. If we move them to the home page we need to make sure that the "Hide Feature Channels" setting still works.

Good point, I think it's okay for the information to be duplicated on the home page as long as the code isn't duplicated (ex: we should set the featuredchannels as part of the home page parsing instead of having a separate method for parsing it).

I'll look into getting the hide featured channels to work with the homepage as well

@ChunkyProgrammer
Copy link
Member Author

Good point, I think it's okay for the information to be duplicated on the home page as long as the code isn't duplicated (ex: we should set the featuredchannels as part of the home page parsing instead of having a separate method for parsing it).

I'll look into getting the hide featured channels to work with the homepage as well

Done: 43aeeef

Copy link
Contributor

github-actions bot commented Nov 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Nov 2, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc

Is it possible to hide shorts when the distraction free setting is enabled?

@ChunkyProgrammer
Copy link
Member Author

Is it possible to hide shorts when the distraction free setting is enabled?

I think it'd be possible to hide some of the shorts on the home page but not all of them (I'll have to double check).

Also, would we want to hide shorts on the home page? I thought the hide shorts setting was just for hiding the shorts tab?

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@PikachuEXE
Copy link
Collaborator

Also, would we want to hide shorts on the home page? I thought the hide shorts setting was just for hiding the shorts tab?

I interpretation is that Hide Channel Shorts is for hiding any displayed shorts in single channel view & channel short tab is the only place before home tab is introduced

@ChunkyProgrammer ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 6, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc

Also, would we want to hide shorts on the home page? I thought the hide shorts setting was just for hiding the shorts tab?

I interpretation is that Hide Channel Shorts is for hiding any displayed shorts in single channel view & channel short tab is the only place before home tab is introduced

Yeah maybe its best to just leave this as is

@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Co-Authored-By: PikachuEXE <1018543+PikachuEXE@users.noreply.github.com>
@ChunkyProgrammer ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: waiting for review For PRs that are complete, tested, and ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants