Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show precise view counts for videos on search results page (Local API) #6284

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

OothecaPickle
Copy link
Contributor

@OothecaPickle OothecaPickle commented Dec 6, 2024

Show precise view counts for videos on search results page

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Description

Shows the precise view counts for videos on the search results page instead of rounded values.

Screenshots

Before:
ft viewCount 1
After:
ft viewCount 2

Testing

Desktop

  • OS: macOS
  • OS Version: 10.13.6
  • FreeTube version: c448b3c

Additional context

Bug introduced in 170e473 (#6033)

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 6, 2024 03:28
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 6, 2024
Copy link
Collaborator

@kommunarr kommunarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great catch!

@OothecaPickle OothecaPickle changed the title Show precise view counts for videos on search results page Show precise view counts for videos on search results page (Local API) Dec 6, 2024
@FreeTubeBot FreeTubeBot merged commit 95e13b5 into FreeTubeApp:development Dec 6, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 6, 2024
jlvivero pushed a commit to jlvivero/FreeTube that referenced this pull request Dec 7, 2024
SuperAKWA pushed a commit to SuperAKWA/FreeTube that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants