Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Don't error when tabs are missing #94

Merged
merged 8 commits into from
Sep 21, 2022
Merged

Don't error when tabs are missing #94

merged 8 commits into from
Sep 21, 2022

Conversation

ChunkyProgrammer
Copy link
Member

closes #90

@PrestonN PrestonN enabled auto-merge (squash) September 13, 2022 14:37
PikachuEXE
PikachuEXE suggested changes Sep 14, 2022
View reviewed changes
app/youtube-grabber.js Outdated Show resolved Hide resolved
@ChunkyProgrammer @PikachuEXE
check for null too
5da8f00 
Co-Authored-By: PikachuEXE <pikachuexe@gmail.com>
PikachuEXE
PikachuEXE previously approved these changes Sep 14, 2022
View reviewed changes
absidue
absidue reviewed Sep 14, 2022
View reviewed changes
app/fetchers/playlist.js Outdated Show resolved Hide resolved
@ChunkyProgrammer ChunkyProgrammer marked this pull request as draft September 14, 2022 10:55
auto-merge was automatically disabled September 14, 2022 10:55

Pull request was converted to draft

absidue
absidue previously approved these changes Sep 14, 2022
View reviewed changes
@ChunkyProgrammer ChunkyProgrammer marked this pull request as ready for review September 14, 2022 11:42
@PrestonN PrestonN enabled auto-merge (squash) September 14, 2022 11:42
PikachuEXE
PikachuEXE suggested changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is important

app/helper.js Outdated Show resolved Hide resolved
@ChunkyProgrammer @PikachuEXE
Improve parameter name
a5c5536 
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
@PrestonN PrestonN merged commit 3d2d60a into FreeTubeApp:development Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dont error when tabs are missing
5 participants
@ChunkyProgrammer @PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @PrestonN