-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove data heavy unused parts of the receipts in gql queries #1709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voxelot
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate and
nedsalk
as code owners
February 2, 2024 21:48
Voxelot
changed the title
remove data heavy unused parts of the receipts in gql queries
chore: remove data heavy unused parts of the receipts in gql queries
Feb 2, 2024
arboleya
reviewed
Feb 2, 2024
@@ -44,15 +44,11 @@ fragment transactionFragment on Transaction { | |||
fragment receiptFragment on Receipt { | |||
contract { | |||
id | |||
bytecode | |||
salt | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if we should remove it from the operations.graphql
. 🤔
We may be able to opt out of these fields for the dry-run calls (on a per-call basis).
Closing in favor of: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #1706
remove fetching of contract bytecode when returning receipts