-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: filter out receipt properties on dryrun #1710
Conversation
Torres-ssf
commented
Feb 2, 2024
- Close: Ensure dry runs request only necessary data #1706
packages/providers/src/transaction-summary/get-transaction-summary.ts
Outdated
Show resolved
Hide resolved
packages/providers/src/transaction-summary/get-transaction-summary.ts
Outdated
Show resolved
Hide resolved
packages/providers/src/transaction-summary/get-transaction-summary.ts
Outdated
Show resolved
Hide resolved
Coverage Report:
Changed Files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥
gasUsed | ||
data | ||
recipient | ||
contractId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be redundant given that contract { id }
is defined above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Torres-ssf Even after my suggestions, this is still a bit off. The dry-run queries will return less data than a few utility methods will require down the road.
I don't think it's worth the risk for this release, so I created another PR here:
This is safer because the removed properties are not used anywhere by any other type. I also fixed a few fragment types, and everything looks okay.
I understand we still have more properties to trim, but I'd suggest doing those in separate PRs with more time to double-check everything.
Closing this if favor of #1715 |