Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add signTransaction to FuelConnectorMethods enum #3128

Merged

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Sep 7, 2024

Release notes

In this release, we:

  • Added signTransaction method to FuelConnectorMethods enum

Summary

This PR adds the signTransaction method to the FuelConnectorMethods enum. This ensures that the Fuel connector manager will correctly initialize any connector implementing this method during the execution of the setupMethods function.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 2:29pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 2:29pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 7, 2024 2:29pm

@Torres-ssf Torres-ssf enabled auto-merge (squash) September 7, 2024 14:30
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Coverage Report:

Lines Branches Functions Statements
79.37%(+0%) 72.15%(+0%) 77.73%(+0%) 79.44%(+0.01%)
Changed Files:

Coverage values did not change👌.

@Torres-ssf Torres-ssf merged commit fb4815e into master Sep 8, 2024
36 of 40 checks passed
@Torres-ssf Torres-ssf deleted the st/feat/add-sign-transaction-to-connectors-method-enum branch September 8, 2024 18:09
Torres-ssf added a commit that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants