Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert add signTransaction to FuelConnectorMethods enum #3149

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Sep 11, 2024

Release notes

In this release, we:

  • Removed signTransaction method from FuelConnectorMethods enum

Summary

This PR reverts #3128.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 4:09pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 4:09pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 11, 2024 4:09pm

@maschad maschad enabled auto-merge (squash) September 11, 2024 16:19
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
78.86%(-0.49%) 71.75%(-0.4%) 77.2%(-0.53%) 78.94%(-0.48%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)
76.71%
(-1.37%)
84%
(+0%)
88.81%
(+0%)
🔴 ✨ packages/account/src/providers/transaction-request/upgrade-transaction-request.ts 18.75%
(+18.75%)
31.57%
(+31.57%)
25%
(+25%)
18.75%
(+18.75%)
🔴 ✨ packages/account/src/providers/transaction-request/upload-transaction-request.ts 31.57%
(+31.57%)
66.66%
(+66.66%)
28.57%
(+28.57%)
31.57%
(+31.57%)
🔴 packages/account/src/providers/transaction-summary/operations.ts 94.21%
(-1.58%)
69.11%
(-2.1%)
93.47%
(+0%)
92.96%
(-1.48%)
🔴 packages/account/src/providers/utils/gas.ts 75.75%
(-18.58%)
85.18%
(-6.82%)
75%
(-17.3%)
76.11%
(-18.33%)

@maschad maschad merged commit c968ac0 into master Sep 11, 2024
23 checks passed
@maschad maschad deleted the st/chore/revert-add-sign-transaction branch September 11, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove signTransaction method from FuelConnectorMethods enum
4 participants