-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding support for proxy contracts in fuels deploy
#3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
CodSpeed Performance ReportMerging #3190 will improve performances by ×2.6Comparing Summary
Benchmarks breakdown
|
4 tasks
arboleya
requested review from
Dhaiwat10,
Torres-ssf,
petertonysmith94,
nedsalk and
maschad
September 25, 2024 18:56
maschad
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
Torres-ssf
approved these changes
Sep 25, 2024
danielbate
approved these changes
Sep 26, 2024
Coverage Report:
Changed Files:
|
This was referenced Sep 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fuels deploy
#3123Release notes
In this release, we:
fuels deploy
Summary
This PR adds support for
proxy
contracts, following the:The CLI command
fuels deploy
mimics the behavior fromforc-deploy
:Note
For an overview, refer also to this flowchart.
Trying it out
To test it out using this PR's tag:
Then, choose a contract and enable
proxy
on its closestForc.toml
file:fuels-ts/packages/fuels/test/fixtures/workspace/contracts/upgradable/Forc.toml
Lines 10 to 11 in 0a80933
Important
If all works well, when you start your app in dev mode via
fuels dev
, you'll see that although the contract is re-deployed after being modified, its ID stays the same in thecontracts.json
file. This happens because that's the ID of the proxy, not the underlying target contract.Checklist