-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend finding components to plugins and executables distributed by forc #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2024
alfiedotwtf
changed the title
Extend finding components to plugins and executables distributed by forc (#652)
Extend finding components to plugins and executables distributed by forc
Oct 27, 2024
alfiedotwtf
force-pushed
the
alfie/is_distributed
branch
from
October 27, 2024 16:46
2abac56
to
81b1180
Compare
JoshuaBatty
reviewed
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we could consider adding 2 more tests here.
#[test]
fn test_resolve_from_name_nonexistent() {
assert!(Component::resolve_from_name("nonexistent-component").is_none());
}
#[test]
fn test_resolve_from_name_case_sensitivity() {
let original = Component::resolve_from_name("forc");
let uppercase = Component::resolve_from_name("FORC");
assert_ne!(original, uppercase);
}
Nice! |
alfiedotwtf
force-pushed
the
alfie/is_distributed
branch
from
October 28, 2024 00:10
81b1180
to
8c82eda
Compare
JoshuaBatty
approved these changes
Oct 28, 2024
…orc (#654) When checking if a component is distributed by forc, we currently only look at forc's direct executables. This needs to be extended to resolve components, plugins, and executables.
alfiedotwtf
force-pushed
the
alfie/is_distributed
branch
from
October 28, 2024 04:41
8c82eda
to
abea586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking if a component is distributed by
forc
, we currently only look atforc
's direct executables. This needs to be extended to resolve components, plugins, and executables.This fixes a few issues found while investigating #665.