-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests and highlight issues with should_panic #683
Conversation
c4fa4da
to
7a83582
Compare
Nice work. Just wondering if we could look at adding some helper functions to cut down on code duplication. Something like fn verify_toolchain_executables(cfg: &TestConfig, component: &Component, toolchain: &Toolchain) {
let toolchain_bin_dir = cfg.toolchain_bin_dir(toolchain.name.as_str());
for executable in &component.executables {
assert!(
toolchain_bin_dir.join(executable).exists(),
"Executable not found: {}",
executable
);
}
} Probably a few places code duplication could be removed. Looks good otherwise. |
7a83582
to
63dbf8e
Compare
63dbf8e
to
a5458af
Compare
297f552
to
7c3e3a3
Compare
7c3e3a3
to
d66011f
Compare
It might be better to remove
|
This PR contains tests that demonstrate inconsistencies found in #654.
Once this PR is merged, the following PRs can then be updated along with removing corresponding
should_panic
test attributes:Since #668 builds on top of the fixes in #666 and #667 and so will have conflicts and duplication, it will need to wait for the above PRs to be merged first before being mergeable.