Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMM: Atomic deposit and add liquidity script #304

Closed
wants to merge 15 commits into from
Closed

AMM: Atomic deposit and add liquidity script #304

wants to merge 15 commits into from

Conversation

supiket
Copy link
Contributor

@supiket supiket commented Nov 29, 2022 •
edited
Loading

Type of change

  • Improvement

Changes

The following changes have been made:

  • A script that atomically deposits and adds liquidity to an exchange contract has been added.

Notes

  • The test that inputs the base asset to the script is currently failing. This is because the SDK is adding fee coins when the script helper is called, so adding a base asset manually as an input causes a problem. This will be fixed soon™.

Related Issues

Closes #287

@supiket supiket added Improvement Enhancing a feature that already exists App: AMM Label used to filter for the app issue labels Nov 29, 2022
@supiket supiket self-assigned this Nov 29, 2022
@supiket supiket mentioned this pull request Dec 2, 2022
Closed
@supiket
Copy link
Contributor Author

supiket commented Dec 10, 2022

Moved to #312 since the newly added test utils module is used by all three scripts.

@supiket supiket closed this Dec 10, 2022
@supiket supiket deleted the supiket/atomic-liquidity-script branch December 10, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@supiket supiket

Labels
App: AMM Label used to filter for the app issue Improvement Enhancing a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AMM: Atomic deposit and add liquidity script
1 participant
@supiket